Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LDAP users lookup to match SMB #215

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck commented Mar 21, 2024

Essentially #214 but for LDAP to make sure there is feature parity

  • allow for specifying specific users to dump for ldap
  • print last password set date
  • print bad password attempt #
  • clean up how ldap attributes are parsed, and functionize this for use elsewhere

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 beautifully matching smb now with #214:
image

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit 3dc84e1 into main Mar 22, 2024
2 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the marshall-ldap-users branch March 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants