Update LDAP active users lookup to match SMB #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termanix
requested review from
zblurx,
Marshall-Hallenbeck,
NeffIsBack and
mpgn
as code owners
line 914 and 916 Comparison edited to "is" Signed-off-by: termanix <[email protected]>
Fixed single quotes and blank spaces Signed-off-by: termanix <[email protected]>
|
Thanks for the PR! That looks quite nice😁 Btw if you have ruff installed with poetry you can just check formatting with |
Signed-off-by: termanix <[email protected]>
I'm trying to fix it, thank you ^^ |
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
…fic user and formating
NeffIsBack
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated as Marshall's #215