Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SMB users lookup and return last password set date #214

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Fix SMB users lookup and return last password set date #214

merged 7 commits into from
Mar 21, 2024

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck commented Mar 20, 2024 •
edited
Loading

  • allow requesting only specific users when calling --users (fixes users user returns all users instead of specified user #203)
  • return LastPwSet in human-readable format for --users
  • remove unnecessary print statement before printing users
  • add in header line for user table
  • add more debug statements in samruser.py
  • print bad password attempt #
  • functionize code for future use, allowing other areas of code to call into these user lookup functions

Example of getting all users:
image

Example of getting specific users:
image

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Mar 20, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Mar 20, 2024
@Marshall-Hallenbeck
fix+feat(smb-users): allow requesting only specific users, print Last…
ce9b766 
…PwSet, and functionize more code for future use
This was referenced Mar 21, 2024
Merged
Closed
@Marshall-Hallenbeck
Copy link
Collaborator Author

It was brought up in #219 that the bad pw count is missing from this feature, so I've re-added it:
image

NeffIsBack
NeffIsBack previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
image

NeffIsBack
NeffIsBack approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better :D

image

@NeffIsBack NeffIsBack merged commit 0608628 into main Mar 21, 2024
2 checks passed
@NeffIsBack NeffIsBack deleted the issue/203 branch March 21, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@mpgn mpgn Awaiting requested review from mpgn mpgn is a code owner

Assignees

@Marshall-Hallenbeck Marshall-Hallenbeck

Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

users user returns all users instead of specified user
2 participants
@Marshall-Hallenbeck @NeffIsBack