Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing data matrices with target scale type without generating new vectors #1281

Open
arteymix opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
cli Issues affecting the CLI enhancement Enhance the code or user experience single cell Issues related to single-cell data support

Comments

@arteymix
Copy link
Member

It should be possible to write data to disk and perform basic conversion between scale types.

This is relevant for single-cell data because we might not have control over the type of data we import.

@arteymix arteymix added the enhancement Enhance the code or user experience label Nov 1, 2024
@arteymix
Copy link
Member Author

arteymix commented Nov 1, 2024

Ok, I'm done with all the possible conversions.

I'm still wondering if we should round data for producing counts...

@arteymix
Copy link
Member Author

arteymix commented Nov 1, 2024

I think rounding is fair if we include a warning because there's always the option of passing LINEAR to get the adjusted counts.

@arteymix arteymix added the single cell Issues related to single-cell data support label Nov 1, 2024
@arteymix arteymix added the cli Issues affecting the CLI label Nov 1, 2024
@arteymix arteymix self-assigned this Nov 1, 2024
@arteymix
Copy link
Member Author

arteymix commented Nov 4, 2024

Ok, this is completed for single-cell data. It also needs to be applied to bulk matrix writers as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues affecting the CLI enhancement Enhance the code or user experience single cell Issues related to single-cell data support
Projects
None yet
Development

No branches or pull requests

1 participant