-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add page for statistical flight log analysis #3534
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Statistical Flight Log Analysis | ||
|
|
||
| This topic contains information and resources related to statistical flight log analysis. | ||
|
|
||
| ## Flight Review Public Logs | ||
|
|
||
| [Flight Review](../log/flight_log_analysis.md#flight-review-online-tool) hosts a large set of publicly available log files that can be used for statistical analysis, machine learning, or other purposes. | ||
|
|
||
| The dataset contains a set of different: | ||
|
|
||
| - vehicle types | ||
| - PX4 versions (including development versions) | ||
| - boards | ||
| - flight modes | ||
|
|
||
| The logs are accessible on [logs.px4.io/browse](https://logs.px4.io/browse) and are licensed under [CC-BY PX4](https://creativecommons.org/licenses/by/4.0/). | ||
|
|
||
| Log files can also be downloaded in bulk with the [download_logs.py](https://github.com/PX4/flight_review/blob/main/app/download_logs.py) script. | ||
| The script allows to filter by different attributes (like flight modes, airframe name or type). | ||
| Use the `--help` flag for a full list. | ||
| The newest logs will be downloaded first, and downloads can be interrupted and resumed later on. | ||
|
|
||
| There are different parsing libraries, for example [pyulog](../log/flight_log_analysis.md#pyulog) can be used to read logs with Python. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng It seems to me that this topic is really "how to download flight review logs", which can then be used for any purpose.
A topic named Statistical Flight Log analysis would seem to me to be about "how you go about doing such an analysis", and it might include information such as where to get public data sets, such as the ones in Flight review.
So proposing that we move this content into Log Analysis using Flight Review. This would be a section at the bottom "Downloading Public Flight Logs". In the introduction perhaps a link or note `Public Flight Review logs can be downloaded for statistical analysis or machine learning: See XXx.
What do you think? I can do this if you think my point is reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's a better description for what it is about.
My reasoning was that I wanted to maximize the chance for someone searching in general to find it (maybe not even knowing about flight review), and that the statistical analysis is the primary use-case for downloading those logs in bulk.
I also thought about adding it to the Log Analysis page, but concluded it's not a good fit as that page is specifically about analyzing a single (or specific set of) logs with the flight review plotting page.
But I'm also not specifically against adding it there if you still think it makes the most sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good points. I've left as is, but added an introduction to the page that makes it clear that this page could grow with other resources when we have them. Still discoverable, but now the title and content match better.