Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page for statistical flight log analysis #3534

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Jan 7, 2025

The question for license for public flight logs came up on https://discuss.px4.io/t/license-for-the-dataset/42819, and in the process of clarifying that, I thought it makes sense to add a short page about the option for statistical log analysis to the docs.

@bkueng bkueng requested a review from hamishwillee January 7, 2025 10:15
@@ -0,0 +1,18 @@
# Statistical Flight Log Analysis
Copy link
Collaborator

@hamishwillee hamishwillee Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkueng It seems to me that this topic is really "how to download flight review logs", which can then be used for any purpose.
A topic named Statistical Flight Log analysis would seem to me to be about "how you go about doing such an analysis", and it might include information such as where to get public data sets, such as the ones in Flight review.

So proposing that we move this content into Log Analysis using Flight Review. This would be a section at the bottom "Downloading Public Flight Logs". In the introduction perhaps a link or note `Public Flight Review logs can be downloaded for statistical analysis or machine learning: See XXx.

What do you think? I can do this if you think my point is reasonable?

Suggested change
# Statistical Flight Log Analysis
# Statistical Flight Log Analysis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's a better description for what it is about.
My reasoning was that I wanted to maximize the chance for someone searching in general to find it (maybe not even knowing about flight review), and that the statistical analysis is the primary use-case for downloading those logs in bulk.
I also thought about adding it to the Log Analysis page, but concluded it's not a good fit as that page is specifically about analyzing a single (or specific set of) logs with the flight review plotting page.
But I'm also not specifically against adding it there if you still think it makes the most sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good points. I've left as is, but added an introduction to the page that makes it clear that this page could grow with other resources when we have them. Still discoverable, but now the title and content match better.

Copy link

No flaws found

@hamishwillee hamishwillee merged commit d567995 into main Jan 23, 2025
2 checks passed
@hamishwillee hamishwillee deleted the public_flight_logs branch January 23, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants