Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added advanced plane documentation #2843

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

frede791
Copy link
Contributor

@frede791 frede791 commented Nov 2, 2023

Add documentation for the Advanced Plane that provides better aerodynamic simulation than the regular plane.
The plane is currently being added to PX4 in PX4/PX4-Autopilot#22167.
The advanced lift drag plugin that forms the centerpiece of the model was merged into Gazebo in gazebosim/gz-sim#2185.

@frede791
Copy link
Contributor Author

frede791 commented Nov 2, 2023

Just noticed the path is wrong. Shouldn't it be going to: ../sim_gazebo_gz/vehicles.md not ../gazebo_vehicles

en/releases/main.md Outdated Show resolved Hide resolved
@hamishwillee
Copy link
Collaborator

I'm good with this (modulo your comments on the release note). I presume though we'll wait on the PX4 PR to merge first?

@frede791
Copy link
Contributor Author

frede791 commented Nov 2, 2023

@hamishwillee Yes, I'll let you know once the advanced plane has been merged into PX4.

@hamishwillee hamishwillee changed the title added advanced plane documentation [WIP] added advanced plane documentation Nov 2, 2023
@hamishwillee
Copy link
Collaborator

Yes, I'll let you know once the advanced plane has been merged into PX4.

Thanks very much. This looks good. Note, I added WIP to the title just to remind me not to merge prematurely.

@frede791
Copy link
Contributor Author

frede791 commented Nov 6, 2023

@hamishwillee The advanced plane has been merged, so this can be merged as well now.
One issue: The advanced lift drag plugin is not yet released as part of the gz distribution. Should we maybe make a note of that on this page somewhere?

Copy link

github-actions bot commented Nov 8, 2023

No flaws found

@hamishwillee
Copy link
Collaborator

One issue: The advanced lift drag plugin is not yet released as part of the gz distribution. Should we maybe make a note of that on this page somewhere?

make px4_sitl gz_advanced_plane seems to work for me on main, so I think that this can merge. What difference would it make for users to add this note?
i.e. if this will affect people then sure, we should add a note as a post process - but it does not appear to.

@hamishwillee hamishwillee merged commit 5f4a52e into PX4:main Nov 8, 2023
1 check passed
@frede791
Copy link
Contributor Author

frede791 commented Nov 8, 2023

@hamishwillee Did you get a plugin error? Because that is what currently happens for me.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 8, 2023

@frede791 I didn't see a plugin error, but now I do.

INFO  [gz_bridge] world: default, model name: advanced_plane_0, simulation model: advanced_plane
[Err] [SystemLoader.cc:119] Failed to load system plugin: (Reason: Could not find shared library)
- Requested plugin name: [gz::sim::systems::AdvancedLiftDrag]
- Requested library name: [gz-sim-advanced-lift-drag-system]
- Library search paths:
  - /home/ubuntu/.gz/sim/plugins/
  - /usr/lib/x86_64-linux-gnu/gz-sim-7/plugins/
  - /home/ubuntu/.ignition/gazebo/plugins/

So yes, if this is actually broken we do need a note. Can you add one? Ideally with a link to issue that we can track to allow us to remove the note when this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants