fix(geometry): CylinderGeometry non-manifold #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Codeboy-cn
commented
Oct 8, 2024
•
Codeboy-cn
commented
- fix end vertex position on cap
- fix missing materials for sub-geometry, use first mat by default
lslzl3000
changed the title
Merged
lslzl3000
added a commit
that referenced
this pull request
Nov 27, 2024
## [0.8.4](v0.8.3...v0.8.4) (2024-11-27) ### Bug Fixes * **destroy:** render error after obj.destroy() ([1e79847](1e79847)) * **extrudeGeometry:** fix shape in CCW order ([a7c8d01](a7c8d01)) * **frameRate:** render on small frameRate ([8b685b9](8b685b9)) * **geometry:** CylinderGeometry non-manifold ([#451](#451)) ([bf14c61](bf14c61)) * **graphic3d:** fix graphic clear & destroy ([eff6082](eff6082)) * **graphics3D:** fix buildCircle with custom up ([8e0354a](8e0354a)) * **pick:** add pick info in bound mode ([3fba2c5](3fba2c5)) * **pick:** add worldNormal in bound pick ([4b5bc9c](4b5bc9c)) * resolve issue with resume() being invoked multiple times ([9b2d7d1](9b2d7d1)) * **type:** refine PointerEvents types ([3029b5c](3029b5c)) ### Features * [WIP] double precision matrix support ([52ab9c5](52ab9c5)) * **ExtrudeGeometry:** add anchor point offset ([#452](#452)) ([fc2303d](fc2303d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.