Skip to content

Home

Jump to bottom
Marcus A Johansson edited this page Jan 30, 2017 · 7 revisions

Process for adding functionality to HiQP

  1. Set up a new enhancement issue stating:
  • the problem the new functionality is supposed to solve
  • the new functionality, how it solves the problem
  • suggestion for a way to implement it
  • suggestion for how to test/evaluate it
  1. The enhancement issue is reviewed and approved in the enhancement issue.
  2. After approval the new functionality is implemented and tested in a separate branch. Commits shall link to the enhancement issue.
  3. When the functionality is properly implemented a pull-request to the devel branch is made.
  4. Eventually the new functionality ends up on master.

Regarding implementation details on GeometricPrimitiveMap

The interface of GeometricPrimitiveMap is designed to always require the type of the geometric primitive to operate on when calling for instance getGeometricPrimitive. Another solution could be to store a type identifier in each subclass of GeometricPrimitive, which can be used once a GeometricPrimitive pointer has been gotten from the map to downcast it to the actual subclass. This latter design choice contains code smells, and the usage of such coding styles will lead to code defects. To quote:

"Dynamic casts are generally a code smell.
Assuming you are using dependency inversion correctly, any dynamic casts in your code should be to a base class. And thanks to the implementation details behind dynamic casts, casting to the base is nearly free.
My guess is you are forgetting your SOLID development principles, particularly the L and D. You should have interfaces for everything, and everything that satisfies the interface is interchangeable. If you need to do a dynamic cast to anything other than the base interface you are probably too dependent on the concrete types.
Invariably over time these grow into serious code defects."
got from https://www.gamedev.net/topic/671003-c-dynamic-cast/

Clone this wiki locally