Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add resetAuthorizedKeys option for the OT-2 #13743

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Oct 9, 2023

Overview

We want to be able to reset the authorized_keys file for the OT-2 as well, so let's add the option to do so.

Test Plan

  • Make sure that we can't ssh into an OT-2 after hitting the /settings/reset endpoint with the AuthorizedKeys option

Changelog

  • add AuthorizedKeys option to list of resettable options for the OT-2

Review requests

Risk assessment

@vegano1 vegano1 requested review from a team as code owners October 9, 2023 15:48
@vegano1 vegano1 requested a review from mjhuff October 9, 2023 15:48
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #13743 (c6e0242) into edge (f40a50d) will not change coverage.
Report is 9 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13743   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files        2450     2450           
  Lines       68862    68862           
  Branches     8202     8202           
=======================================
  Hits        48859    48859           
  Misses      18071    18071           
  Partials     1932     1932           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/config/reset.py 88.88% <ø> (ø)

@vegano1 vegano1 requested a review from sfoster1 October 9, 2023 16:04
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vegano1 vegano1 merged commit c21d1bb into edge Oct 9, 2023
@vegano1 vegano1 deleted the clear_ssh_keys_ot2 branch October 9, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants