-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add AuthorizedKeys reset option for the OT-2 + fixes #13745
feat(api): add AuthorizedKeys reset option for the OT-2 + fixes #13745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.1 #13745 +/- ##
=======================================================
- Coverage 71.24% 71.24% -0.01%
=======================================================
Files 2429 2429
Lines 68430 68434 +4
Branches 8040 8040
=======================================================
Hits 48755 48755
- Misses 17776 17780 +4
Partials 1899 1899
Flags with carried forward coverage won't be shown. Click here to find out more.
|
skip hidden files when searching for public keys accept ecdsa keys as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to handling keys look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on an OT-2 and works! Code makes sense per in-person convo.
report that keys were added if they are valid even if they already exist on the bot, so they get feedback on the operation.
Overview
This change should have been merged into the
chore_release-7.0.1
branch but was merged toedge
instead. So let's Cherry-pick the commit from edge and retarget to7.0.1
release branch. Original pr can be found here. This pr also adds a few improvements to the/from_keys
function, we now skip hidden (.) files, we handle errors so we don't stop processing all pub keys found if one of them fails to open, we now acceptecdsa
keys like the OT-2.Test Plan
ssh_keys/from_local
endpoint to add ssh keys from a USB drivessh_keys/from_local
endpoint and make sure you can ssh..pub
and make sure we skip itChangelog
ecdsa
as a valid public key type to match the OT-2Review requests
Risk assessment