fix(hardware): wrong val for dummy moves #13679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13679 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 2438 2438
Lines 68526 68526
Branches 8090 8090
=======================================
Hits 48727 48727
Misses 17905 17905
Partials 1894 1894
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ahiuchingau
force-pushed
the
fix_dummy-val-in-move-manager
branch
from
6edf1fb to
e6bdb3c
Compare
ahiuchingau
requested review from
brenthagen
and removed request for
a team
caila-marashaj
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've been using the wrong values in the dummy moves that probably got added from a gnarly rebase, but this is not going to affect actual move behaviors.