Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): add custom & default thermocycler overlap offsets for labware #13630

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Sep 22, 2023

Overview

Closes RSS-353

  • Adds the stackingOverlapWithModule for Biorad & NEST PCR plates on TC Gen2.
  • Also adds a default overlap for any labware placed on a thermocycler on the OT2 such that the final height of the labware is the same as what it would have been prior to introducing stacking overlaps for thermocycler labware.

Test Plan

The ticket above has a protocol attached for testing. That protocol places a nest PCR plate, a biorad plate and a custom pcr plate on the thermocycler one ofter the other to check for location precision. You will need to create and upload a custom PCR plate definition as mentioned in the protocol.

  1. Upload this protocol to a Flex and check that:

    • when you run LPC, the pipette moves to accurate z-positions for the NEST and Biorad plates, and moves too high for the custom pcr plate
    • during the protocol run the gripper is able to move the NEST & biorad plates correctly but can't move the custom pcr plate because the gripper moves too high
  2. Adjust the protocol for running on OT2 and upload to an OT2:

    • when you run LPC, the pipette moves to accurate z-positions for the NEST and Biorad plates, and an okay position for custom pcr plate (unless it happens to be based on an armadillo plate). Also note that positional accuracy of the OT2 for labware on modules is not as high as the Flex so I wouldn't stress too much if there is an offset of a couple of mm.

Changelog

  • updated Biorad & NEST PCR plate definitions
  • added backwards-compatible stacking overlap for OT2 based TC in state.labware. get_module_overlap_offsets()

Review requests

  • Do above tests on both Flex & OT-2
  • Do we need to bump labware definition revision number for this?

Risk assessment

Low. Just adds the missing overlap values. Low risk if tests show expected results.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #13630 (84d1aca) into chore_release-7.0.1 (1adcabd) will not change coverage.
Report is 3 commits behind head on chore_release-7.0.1.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.1   #13630   +/-   ##
====================================================
  Coverage                71.25%   71.25%           
====================================================
  Files                     2429     2429           
  Lines                    68405    68405           
  Branches                  8033     8033           
====================================================
  Hits                     48740    48740           
  Misses                   17769    17769           
  Partials                  1896     1896           
Flag Coverage Δ
app 68.78% <ø> (ø)
g-code-testing 96.44% <ø> (ø)
labware-library 49.17% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 46.09% <ø> (ø)
shared-data 74.10% <ø> (ø)
step-generation 86.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/protocol_engine/state/labware.py 100.00% <ø> (ø)
app/src/App/hooks.ts 10.34% <ø> (ø)

@SyntaxColoring
Copy link
Contributor

Measurements look good so far on an OT-2.
Screenshot 2023-09-22 at 3 08 39 PM

@sanni-t
Copy link
Member Author

sanni-t commented Sep 22, 2023

Measurements look good so far on an OT-2.

🙌 Thanks for the thorough testing! @SyntaxColoring

@jbleon95
Copy link
Contributor

Measurements look good on the Flex
Screen Shot 2023-09-25 at 12 35 14 PM

@sanni-t sanni-t changed the base branch from edge to chore_release-7.0.1 September 28, 2023 14:53
@sanni-t sanni-t marked this pull request as ready for review September 29, 2023 20:26
@sanni-t sanni-t requested a review from a team as a code owner September 29, 2023 20:26
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes—does this need updates to G-code tests?

@sanni-t
Copy link
Member Author

sanni-t commented Oct 4, 2023

LGTM if CI passes—does this need updates to G-code tests?

Not sure. Checking now. Did we resolve the g-code test failure issues on the release branch?

The PD & Labware library tests are failing on all PRs because of some CI chrome version issue so going to ignore those failures.

@SyntaxColoring
Copy link
Contributor

Not sure. Checking now. Did we resolve the g-code test failure issues on the release branch?

Yes, as far as I know.

The PD & Labware library tests are failing on all PRs because of some CI chrome version issue so going to ignore those failures.

👍 Yep. #13705 (review)

@jerader jerader requested a review from a team as a code owner October 6, 2023 20:48
@jerader jerader requested review from TamarZanzouri and removed request for a team October 6, 2023 20:48
@sanni-t sanni-t merged commit 11b35ed into chore_release-7.0.1 Oct 9, 2023
57 checks passed
jerader added a commit that referenced this pull request Oct 10, 2023
…for labware (#13630)

* added TC overlaps for nest & biorad pcr plates
* added a backwards-compatible default overlap for TC labware on OT2
* fix pd e2e migration fixture
---------

Co-authored-by: Jethary <[email protected]>
jerader added a commit that referenced this pull request Oct 10, 2023
…for labware (#13630)

* added TC overlaps for nest & biorad pcr plates
* added a backwards-compatible default overlap for TC labware on OT2
* fix pd e2e migration fixture
---------

Co-authored-by: Jethary <[email protected]>
jerader added a commit that referenced this pull request Oct 10, 2023
…for labware (#13630) (#13750)

* added TC overlaps for nest & biorad pcr plates
* added a backwards-compatible default overlap for TC labware on OT2
* fix pd e2e migration fixture
---------

Co-authored-by: Sanniti Pimpley <[email protected]>
@sanni-t sanni-t deleted the update_TC_compatible_labware branch July 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants