feat(shared-data): add custom & default thermocycler overlap offsets … #13750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for labware (#13630) * added TC overlaps for nest & biorad pcr plates * added a backwards-compatible default overlap for TC labware on OT2 * fix pd e2e migration fixture --------- Co-authored-by: Jethary <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## pd_release-7.0.0 #13750 +/- ##
=================================================
Coverage 71.29% 71.29%
=================================================
Files 2424 2424
Lines 68203 68203
Branches 7975 7975
=================================================
Hits 48622 48622
Misses 17711 17711
Partials 1870 1870
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for labware (#13630)
Overview
cherry picked this pr: #13630 to add to PD 7.0.0 release
Test Plan
TC testing Flex.json
testing TC OT-2.json
custom_labware_96_wells.json
See protocols + custom labware attached to this PR and please test on
chore_release-7.0.1, the cherry-picked commit isn't in an alpha yet so just make sure you're up to date with that branch.This test plan is copied over from the cherry picked PR:
The protocols place a nest PCR plate, a biorad plate and a custom pcr plate on the thermocycler one ofter the other to check for location precision.
Upload Flex protocol and check that:
Upload OT-2 protocol and check that:
Changelog
Review requests
Risk assessment
low, already has been tested on the release branch