Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Fix for build break Defect 303094 #30570

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Issue Fix for build break Defect 303094 #30570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...g/fat/src/com/ibm/ws/concurrent/persistent/fat/locking/PXLockTestWithFailoverEnabled.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public static void tearDown() throws Exception {
runInServlet("verifyTasksRunMultipleTimes");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright at top of file needs to increase the 2nd year to 2025

} finally {
// wait for tasks to stop running
long waitForTaskCompletions = TimeUnit.SECONDS.toMillis(10);
long waitForTaskCompletions = TimeUnit.SECONDS.toMillis(60);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusting this time will not have any impact on the failures reported by the BB defect, and will unnecessarily delay the completion of the test. I'd recommend not modifying this time.

The test is failing because the tasks are not completing within the specified missedTaskThreshold, which is configured on line 109. Instead of updating the sleep time here, I'd recommend updating the missedTaskThreshold on line 109, but perhaps not by such a large amount, as it may impact other timing in the test. Perhaps increase 109 from 10 to 25.

Thread.sleep(waitForTaskCompletions);
server.stopServer("CWWKC1511W.*CancellationException" // task execution failed because it was canceled
);
Expand Down