Issue Fix for build break Defect 303094 #30570
Conversation
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
| @@ -136,7 +136,7 @@ public static void tearDown() throws Exception { | |||
| runInServlet("verifyTasksRunMultipleTimes"); | |||
| } finally { | |||
| // wait for tasks to stop running | |||
| long waitForTaskCompletions = TimeUnit.SECONDS.toMillis(10); | |||
| long waitForTaskCompletions = TimeUnit.SECONDS.toMillis(60); | |||
There was a problem hiding this comment.
Adjusting this time will not have any impact on the failures reported by the BB defect, and will unnecessarily delay the completion of the test. I'd recommend not modifying this time.
The test is failing because the tasks are not completing within the specified missedTaskThreshold, which is configured on line 109. Instead of updating the sleep time here, I'd recommend updating the missedTaskThreshold on line 109, but perhaps not by such a large amount, as it may impact other timing in the test. Perhaps increase 109 from 10 to 25.
| @@ -136,7 +136,7 @@ public static void tearDown() throws Exception { | |||
| runInServlet("verifyTasksRunMultipleTimes"); | |||
There was a problem hiding this comment.
Copyright at top of file needs to increase the 2nd year to 2025
There was a problem hiding this comment.
Increasing the transaction timeout
The changes within this PR do not increase the transaction timeout, nor do they increase the missedTaskThreshold as Tracy points out.
The team owning this bucket needs to spend time to understand what the test is doing, perform investigation of the failure, and write up a description of the problem in the issue or PR as they understand and how they are expecting to solve it. It is not the place of the code reviewer to do that work instead. That would be backwards. The only work I see here documenting any investigation or analysis is all from Brian before transferring this defect over, and from Tracy in attempting to review it.
You can use the information they have kindly provided, but you need to perform your own analysis taking that into account and be able to explain and justify whatever change you are making.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Increasing the transaction timeout