Feature/add sv

[simedroniraluca]

No description provided.

[ruxandra-valcu]

I would like the Sv file to also include metadata: lat/lon, depth and beam angle data, for later use. All these can be found in the echopype.consolidate module

[simedroniraluca]

I would like the Sv file to also include metadata: lat/lon, depth and beam angle data, for later use. All these can be found in the echopype.consolidate module

@ruxandra-valcu Given that the add_depth(), add_location(), and add_splitbeam_angle() functions from the echopype.consolidate module have default parameters that work independently of the optional parameters in Sv, I'm thinking it might not be the best practice to include depth, location, and splitbeam angle right here. What if we create a separate L2 module for that? This would give us an Sv with more flexibility. Also, I feel loading up the compute_sv() function with extra logic beyond its main task might not be the way to go. What do you think?

[ruxandra-valcu]

This would give us an Sv with more flexibility. Also, I feel loading up the compute_sv() function with extra logic beyond its main task might not be the way to go. What do you think?

Sure, sounds good. The splitbeam in particular is stuff we'll need for false bottom detection so it was more on my mind, but you're right that adding all the functionality would be better. I'll make an issue

[ruxandra-valcu]

All good

[simedroniraluca]

This would give us an Sv with more flexibility. Also, I feel loading up the compute_sv() function with extra logic beyond its main task might not be the way to go. What do you think?

Sure, sounds good. The splitbeam in particular is stuff we'll need for false bottom detection so it was more on my mind, but you're right that adding all the functionality would be better. I'll make an issue

I will take the issue to resolve (maybe I will need this PR merged for a better integration)

[mihaiboldeanu]

The code looks good it just has the same limitation with this comment .

The test should be split into fixtures for getting the files. Maybe that could be added to conftest.py to have all file download/manipulations in a common place as they may be used in multiple locations.

[simedroniraluca]

The code looks good it just has the same limitation with this comment .

The test should be split into fixtures for getting the files. Maybe that could be added to conftest.py to have all file download/manipulations in a common place as they may be used in multiple locations.

About the sonar models part: In echopype, only some models can compute Sv. Though many provide echodata, not all support Sv computation.

[ruxandra-valcu]

The test should be split into fixtures for getting the files. Maybe that could be added to conftest.py to have all file download/manipulations in a common place as they may be used in multiple locations.

Opened a ticket for that at #40

[mihaiboldeanu]

Looks good!