Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/read raw files #31

Merged
merged 14 commits into from
Sep 14, 2023
Merged

Feature/read raw files #31

merged 14 commits into from
Sep 14, 2023

Conversation

mihaiboldeanu
Copy link
Collaborator

Closed issue #8 with this PR.

  • All functionality described in that issue are done and tested

@simedroniraluca
Copy link
Collaborator

Have you considered consolidating all constants into a dedicated settings module?

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Raluca Simedroni <[email protected]>
Copy link
Collaborator

@ruxandra-valcu ruxandra-valcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

.gitignore Outdated Show resolved Hide resolved
@beatfactor
Copy link
Member

Can we also have the tests run in Github Actions?

@beatfactor beatfactor linked an issue Sep 14, 2023 that may be closed by this pull request
9 tasks
@beatfactor beatfactor merged commit c9ee8dc into dev Sep 14, 2023
1 check passed
@beatfactor beatfactor deleted the feature/read_raw_files branch September 14, 2023 17:25
@mihaiboldeanu mihaiboldeanu mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L0: Reading and Concatenating Raw Files
4 participants