Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky file test by resetting the session #3517

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix flaky file test by resetting the session #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/dashboard/test/system/batch_connect_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,8 +1444,8 @@ def make_bc_app(dir, form)
def get_favorites
# For debugging flaky tests
favorites = all('#favorites li', wait: 30)
puts "FAVORITES: "
puts favorites.map{|i| i['innerHTML']}.join('')
# puts "FAVORITES: "
# puts favorites.map{|i| i['innerHTML']}.join('')
Comment on lines +1447 to +1448
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't a part of this really - I just wanted to get rid of this stdout in tests.

favorites
end

Expand Down
1 change: 1 addition & 0 deletions apps/dashboard/test/system/files_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class FilesTest < ApplicationSystemTestCase
def setup
FileUtils.rm_rf(DOWNLOAD_DIRECTORY.to_s)
FileUtils.mkdir_p(DOWNLOAD_DIRECTORY.to_s)
Capybara.reset_session!
end

test "visiting files app doesn't raise js errors" do
Expand Down
Loading