Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky file test by resetting the session #3517

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

johrstrom
Copy link
Contributor

fix flaky file test by resetting the session

Fixes #3492

Comment on lines +1447 to +1448
# puts "FAVORITES: "
# puts favorites.map{|i| i['innerHTML']}.join('')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't a part of this really - I just wanted to get rid of this stdout in tests.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johrstrom johrstrom merged commit a0c708d into master Apr 22, 2024
23 checks passed
@johrstrom johrstrom deleted the flaky-file-test branch April 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

another flaky test in
3 participants