First stab at hip linear algebra #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
commented
Oct 27, 2023
Comment on lines
+39
to
+47
|
|
||
| virtual int matvec(matrix::Sparse* A, | ||
| vector_type* vec_x, | ||
| vector_type* vec_result, | ||
| const real_type* alpha, | ||
| const real_type* beta, | ||
| std::string matrix_type); | ||
|
|
||
| virtual int Matrix1Norm(matrix::Sparse *A, real_type* norm); |
There was a problem hiding this comment.
Indentation:
Suggested change
| virtual int matvec(matrix::Sparse* A, | |
| vector_type* vec_x, | |
| vector_type* vec_result, | |
| const real_type* alpha, | |
| const real_type* beta, | |
| std::string matrix_type); | |
| virtual int Matrix1Norm(matrix::Sparse *A, real_type* norm); | |
| virtual int matvec(matrix::Sparse* A, | |
| vector_type* vec_x, | |
| vector_type* vec_result, | |
| const real_type* alpha, | |
| const real_type* beta, | |
| std::string matrix_type); | |
| virtual int Matrix1Norm(matrix::Sparse *A, real_type* norm); |
Comment on lines
+74
to
+75
| } | ||
| } // namespace ReSolve |
There was a problem hiding this comment.
Braces positioning (we do need to start using lint):
Suggested change
| } | |
| } // namespace ReSolve | |
| } | |
| } // namespace ReSolve |
pelesh
added a commit
that referenced
this pull request
Oct 28, 2023
Co-authored-by: kswirydo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work in branch
hip-first-take-devis mainly complete, but there are some CMake issues preventing it to be merged and ready to develop. I suggest we use this branch (with periodical rebasing todevelop) to continue porting to HIP.The plan is to have a branch with functional matrix and optionally vector handler ready to merge to
developbefore the Frontier hackathon.