Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build staged #436

Merged
merged 14 commits into from
May 25, 2024
Merged

Docker build staged #436

merged 14 commits into from
May 25, 2024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented May 24, 2024

fixes #416
fixes #417
fixes #434
fixes #427

@bertsky
Copy link
Collaborator Author

bertsky commented May 24, 2024

Does anyone know why CircleCI (again) does not get triggered?

Copy link
Collaborator

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate pull requests for the commits that are not related to the staged Docker build. Some commits are easy to review and could be merged fast, but 11 commits in a single pull request makes it much more difficult to review, at least for me.

It would also be good to update ocrd_tesserocr with the latest Tesseract which includes several important improvements. Currently it uses a two months old release.

@stweil
Copy link
Collaborator

stweil commented May 24, 2024

Does anyone know why CircleCI (again) does not get triggered?

I have no idea, but found only one other pull request where CircleCI did not run. Maybe both pull requests have something in common which prevents the CI runs?

@bertsky
Copy link
Collaborator Author

bertsky commented May 24, 2024

Please create separate pull requests for the commits that are not related to the staged Docker build. Some commits are easy to review and could be merged fast, but 11 commits in a single pull request makes it much more difficult to review, at least for me.

It would also be good to update ocrd_tesserocr with the latest Tesseract which includes several important improvements. Currently it uses a two months old release.

That's an unreasonable demand. We had no release for a long time, CI did not work for multiple reasons. This is the first attempt to get a workable ocrd_all again – I have to combine multiple changes, otherwise it would be without merit.

@stweil
Copy link
Collaborator

stweil commented May 25, 2024

I have to combine multiple changes, otherwise it would be without merit.

Then good luck. I won't be able to review this pull request further.

@bertsky
Copy link
Collaborator Author

bertsky commented May 25, 2024

I triggered CI manually on my fork:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants