Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build (ocrd_detectron2) #434

Closed
stweil opened this issue May 23, 2024 · 2 comments · Fixed by #436
Closed

Broken build (ocrd_detectron2) #434

stweil opened this issue May 23, 2024 · 2 comments · Fixed by #436
Labels
bug Something isn't working

Comments

@stweil
Copy link
Collaborator

stweil commented May 23, 2024

See bertsky/ocrd_detectron2#29 for details. It is broken with any Python version.

@stweil stweil added the bug Something isn't working label May 23, 2024
@bertsky
Copy link
Collaborator

bertsky commented May 25, 2024

Ah, now I get what's really going on. It's still broken on master, but I could not reproduce elsewhere, because it's a bit fuzzy: it depends on whether kraken or detectron2 get installed first. If Kraken makes it, then due to its torch~=2.1 requirement, we end up with pypa/setuptools#4385.

@bertsky bertsky reopened this May 25, 2024
@bertsky
Copy link
Collaborator

bertsky commented May 25, 2024

No, wait. That CI failure was from your merge. The current master with my #436 is fine.

And the reason this works is because I moved ocrd_kraken to the sub-venv, where it can install its own Pytorch independent of Detectron2.

@bertsky bertsky closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants