[16.0][MIG] web_notify: Migration to 16.0 #2412

baimont · 2023-02-17T09:32:42Z

#2309

Tested locally using the Test web notify tab on users

FrancoMaxime

LGTM

sbejaoui

Functional test.

tarteo · 2023-02-22T14:00:02Z

/ocabot migration 16.0

alexis-via · 2023-02-23T22:33:33Z

While testing web_notify in v16 with the module currency_old_rate_notify, I found 2 problems:

in v14, it was working well when "message" contained HTML. In v16, the HTML code of "message" is displayed as text !
if target is not set, then the message is displayed to self.env.user and not to the user on which the method was called !!!

In the method _notify_channel(), you have:

if not target:
            target = self.env.user.partner_id

it should be:

if not target:
            target = self.partner_id

If you don't accept this change, you need to make it very clear in the documentation that, if you don't use the target argument, the message is NOT sent to the user on which you called the method, but to the current user!!!

baimont · 2023-02-28T09:14:21Z

if target is not set, then the message is displayed to self.env.user and not to the user on which the method was called !!!

In the method _notify_channel(), you have:
if not target:
            target = self.env.user.partner_id
it should be:
if not target:
            target = self.partner_id
If you don't accept this change, you need to make it very clear in the documentation that, if you don't use the target argument, the message is NOT sent to the user on which you called the method, but to the current user!!!

Done

baimont · 2023-02-28T11:17:37Z

in v14, it was working well when "message" contained HTML. In v16, the HTML code of "message" is displayed as text !

Concerning this, I believe it is due to the t-out attribute here https://github.com/odoo/odoo/blob/d594069767cb0f48c829a25f33abc6da620e7235/addons/web/static/src/core/notifications/notification.xml#L12

But as I am not familiar with owl I'm not sure what's a good way to fix this. If anyone has an idea, you're welcome fixing it with a new commit.

pedrobaeza · 2023-03-04T17:57:50Z

/ocabot migration web_notify

nguyenminhchien

lgtm

nguyenminhchien · 2023-04-10T10:29:01Z

in v14, it was working well when "message" contained HTML. In v16, the HTML code of "message" is displayed as text !

Concerning this, I believe it is due to the t-out attribute here https://github.com/odoo/odoo/blob/d594069767cb0f48c829a25f33abc6da620e7235/addons/web/static/src/core/notifications/notification.xml#L12

But as I am not familiar with owl I'm not sure what's a good way to fix this. If anyone has an idea, you're welcome fixing it with a new commit.

Hello @baimont i just created this PR to help you show a html formatted message.
Please review it.

baimont · 2023-04-11T07:39:11Z

in v14, it was working well when "message" contained HTML. In v16, the HTML code of "message" is displayed as text !

Concerning this, I believe it is due to the t-out attribute here https://github.com/odoo/odoo/blob/d594069767cb0f48c829a25f33abc6da620e7235/addons/web/static/src/core/notifications/notification.xml#L12
But as I am not familiar with owl I'm not sure what's a good way to fix this. If anyone has an idea, you're welcome fixing it with a new commit.

Hello @baimont i just created this PR to help you show a html formatted message. Please review it.

Thanks very much @nguyenminhchien ! Tested and approved

This technical module allows you to send instant notification messages from the server to the user in live.

Fix a check when comparing a user count with items within a mock call. The previous method was succeeding by pure luck because OCA test databases contain 2 users, which happens to be the amount of items within a mock "call_args" (it contains args + kwargs).

- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.

Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/

Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/

Currently translated at 42.8% (9 of 21 strings) Translation: web-14.0/web-14.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_notify/nl/

It exists since many version and is actively maintained.

- Use ES6 in js files - Update screenshots - Clean old lint exceptions - New icon TT38350

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/

Currently translated at 100.0% (18 of 18 strings) Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/it/

marielejeune · 2023-04-11T13:37:06Z

Hi,
Thanks for the work.
There is an issue: notifications are not popping as soon as we use workers.

web_notify/views/res_users_demo.xml

sbidoul · 2023-04-19T09:53:21Z

There is an issue: notifications are not popping as soon as we use workers.

After further investigation with @marielejeune we found the issue was not related to workers but to Chrome blocking web socket due to an invalid certificate. So this should be good to go.

/ocabot merge nobump

OCA-git-bot · 2023-04-19T09:53:43Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2412-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-19T09:59:04Z

Congratulations, your PR was merged at a80e52b. Thanks a lot for contributing to OCA. ❤️

pedrobaeza · 2023-04-19T18:04:27Z

@sbidoul remember that you enabled a runboat certificate (changing http to https) for these cases 😄

baimont force-pushed the 16.0-mig-web_notify branch from 4a702c5 to d0dd193 Compare February 17, 2023 09:39

FrancoMaxime approved these changes Feb 17, 2023

View reviewed changes

baimont mentioned this pull request Feb 17, 2023

[PRE-COMMIT] fix pre-commit #2413

Closed

baimont force-pushed the 16.0-mig-web_notify branch 2 times, most recently from 7519689 to d81d637 Compare February 17, 2023 13:23

sbejaoui approved these changes Feb 21, 2023

View reviewed changes

OCA-git-bot added the approved label Feb 21, 2023

sbejaoui mentioned this pull request Feb 22, 2023

[16.0][ADD] - add shipment_advice_planner_toursolver OCA/stock-logistics-transport#91

Merged

OCA-git-bot added this to the 16.0 milestone Feb 22, 2023

OCA-git-bot mentioned this pull request Feb 22, 2023

Migration to version 16.0 #2309

Open

46 tasks

lmignon approved these changes Feb 23, 2023

View reviewed changes

alexis-via mentioned this pull request Feb 23, 2023

[16.0][MIG] currency_old_rate_notify OCA/currency#165

Merged

nguyenminhchien approved these changes Apr 10, 2023

View reviewed changes

lmignon and others added 10 commits April 11, 2023 09:53

New module web_notify

3782317

This technical module allows you to send instant notification messages from the server to the user in live.

[MIG] Make modules uninstallable

e5492a6

[MIG] Migration started web_notify

09884d7

[FIX] Return result of super of show_application

39b8859

Update web_client.js

337bad3

OCA Transbot updated translations from Transifex

65aa2ad

[MIG] web_notify: Migration to 11.0

00e4d9c

- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.

Translated using Weblate (Portuguese (Brazil))

a524f9e

Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/

Translated using Weblate (Danish)

957c9b8

Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/

bosd and others added 15 commits April 11, 2023 09:53

Added translation using Weblate (Dutch)

1f8b670

Translated using Weblate (Dutch)

606450b

Currently translated at 42.8% (9 of 21 strings) Translation: web-14.0/web-14.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_notify/nl/

web_notify: bump dev status

7bf3234

It exists since many version and is actively maintained.

[UPD] README.rst

1c7e23c

web_notify 14.0.1.0.1

2d8317d

[MIG] web_notify: Migration to 15.0

dafee50

[IMP] web_notify: migration improvements

6fa8ac4

- Use ES6 in js files - Update screenshots - Clean old lint exceptions - New icon TT38350

[UPD] Update web_notify.pot

18c4856

[UPD] README.rst

4d8f28a

Update translation files

b775091

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/

Added translation using Weblate (Italian)

030d064

Translated using Weblate (Italian)

7661716

Currently translated at 100.0% (18 of 18 strings) Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/it/

[IMP] web_notify: pre-commit stuff

dfa4146

[MIG] web_notify: Migration to 16.0

50dcada

[MIG] web_notify: if not target then take self.partner_id

28b8e6d

baimont force-pushed the 16.0-mig-web_notify branch 2 times, most recently from 785a4fc to 4723fa3 Compare April 11, 2023 07:56

[ADD] show message under html format

f099779

baimont force-pushed the 16.0-mig-web_notify branch from 4723fa3 to f099779 Compare April 11, 2023 08:03

sbidoul reviewed Apr 19, 2023

View reviewed changes

web_notify/views/res_users_demo.xml Show resolved Hide resolved

OCA-git-bot added the bot is merging ⏳ label Apr 19, 2023

OCA-git-bot merged commit b05f180 into OCA:16.0 Apr 19, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 19, 2023

sbidoul deleted the 16.0-mig-web_notify branch April 19, 2023 10:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] web_notify: Migration to 16.0 #2412

[16.0][MIG] web_notify: Migration to 16.0 #2412

baimont commented Feb 17, 2023 •

edited

Loading

FrancoMaxime left a comment

sbejaoui left a comment

tarteo commented Feb 22, 2023

alexis-via commented Feb 23, 2023

baimont commented Feb 28, 2023

baimont commented Feb 28, 2023

pedrobaeza commented Mar 4, 2023

nguyenminhchien left a comment

nguyenminhchien commented Apr 10, 2023

baimont commented Apr 11, 2023

marielejeune commented Apr 11, 2023

sbidoul commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

pedrobaeza commented Apr 19, 2023

[16.0][MIG] web_notify: Migration to 16.0 #2412

[16.0][MIG] web_notify: Migration to 16.0 #2412

Conversation

baimont commented Feb 17, 2023 • edited Loading

FrancoMaxime left a comment

Choose a reason for hiding this comment

sbejaoui left a comment

Choose a reason for hiding this comment

tarteo commented Feb 22, 2023

alexis-via commented Feb 23, 2023

baimont commented Feb 28, 2023

baimont commented Feb 28, 2023

pedrobaeza commented Mar 4, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

nguyenminhchien commented Apr 10, 2023

baimont commented Apr 11, 2023

marielejeune commented Apr 11, 2023

sbidoul commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

pedrobaeza commented Apr 19, 2023

baimont commented Feb 17, 2023 •

edited

Loading