Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] - add shipment_advice_planner_toursolver #91

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[16.0][ADD] - add shipment_advice_planner_toursolver #91

merged 1 commit into from
Feb 28, 2024

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Feb 21, 2023 •
edited
Loading

This module extend the shipment advice planner engine to add a new planning
method based on geo-localization. It uses the GEOCONCEPT solution called
TourSolver to plan the shipment advices according to the location of the customers
by calculating the best route according to the available resources.

@sbejaoui sbejaoui marked this pull request as draft February 21, 2023 00:35
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 2 times, most recently from 1c8957a to 48e02ad Compare February 21, 2023 00:46
lmignon
lmignon suggested changes Feb 21, 2023
View reviewed changes
shipment_advice_planner_toursolver/models/res_partner.py Show resolved Hide resolved
shipment_advice_planner_toursolver/models/res_partner.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_backend.py Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_backend.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_backend.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_delivery_week_day.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_delivery_window.py Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_resource.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_task.py Outdated Show resolved Hide resolved
shipment_advice_planner_toursolver/models/toursolver_task.py Outdated Show resolved Hide resolved
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 2 times, most recently from 15e8696 to 81d53f3 Compare February 21, 2023 22:28
@sbejaoui sbejaoui requested a review from lmignon February 22, 2023 09:37
@sbejaoui sbejaoui marked this pull request as ready for review February 22, 2023 09:55
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 2 times, most recently from 353d7b7 to 5318df2 Compare February 22, 2023 10:10
@sbejaoui sbejaoui mentioned this pull request Feb 22, 2023
Merged
@sbejaoui sbejaoui requested a review from lmignon February 27, 2023 07:28
lmignon
lmignon approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review + functional)

lmignon
lmignon suggested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little change

shipment_advice_planner_toursolver/__manifest__.py Outdated Show resolved Hide resolved
@sbejaoui sbejaoui requested a review from lmignon February 27, 2023 16:57
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch from 6a3ca36 to aea9ba2 Compare March 31, 2023 12:59
@glitchov glitchov force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 3 times, most recently from 8f6b40d to d11dc36 Compare May 3, 2023 06:46
@rousseldenis rousseldenis added this to the 16.0 milestone May 3, 2023
@glitchov glitchov force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 2 times, most recently from 81a0b70 to f520def Compare May 3, 2023 07:53
@jbaudoux jbaudoux changed the title [ADD] - add shipment_advice_planner_toursolver [16.0][ADD] - add shipment_advice_planner_toursolver Jul 4, 2023
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 3 times, most recently from 048a073 to 6d14d2f Compare September 1, 2023 10:55
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 31, 2023
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch 2 times, most recently from 68305b5 to eaf6906 Compare January 22, 2024 08:41
@sbejaoui
Copy link
Contributor Author

ready to merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 28, 2024
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch from 01ce5d8 to 0de7ce5 Compare February 28, 2024 16:28
@sbejaoui
[ADD] - add shipment_advice_planner_toursolver
936be4f 
This module extend the shipment advice planner engine to add a new planning
method based on geo-localization. It uses the GEOCONCEPT solution called
TourSolver to plan the shipment advices according to the location of the customers
by calculating the best route according to the available resources.

[IMP] - depends on base_time_window

[IMP] - add backend options as property field

[IMP] - improve UI and readme

[IMP] - add picking rank

[FIX] - add vcrpy-unittest to test-requirements.txt

[FIX] - group pickings to plan by picking type instead of the warehouse

[IMP] shipment_advice_planner_toursolver : fr translations

[IMP] add vcrpy-unittest

[FIX] - fix typo

[IMP] - allow toursolver task cancel

[IMP] - raise an exception if the toursolver backend is not configured

[IMP] - group system can delete toursolver tasks

[FIX] - don't copy toursolver task when duplicating a picking

[IMP] show toursolver rank in toursolver task

[IMP] add search for can_be_planned_in_shipment_advice

[IMP] shipment_advice_planner_toursolver: add unit tests

[IMP] allow more info in toursolver task name
@sbejaoui sbejaoui force-pushed the 16.0-shipment_advice_planner_toursolver-sbj branch from 0de7ce5 to 936be4f Compare February 28, 2024 16:30
rousseldenis
rousseldenis approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. In production for months

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-91-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 02afdaa into OCA:16.0 Feb 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d9064c. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-shipment_advice_planner_toursolver-sbj branch April 15, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giarve giarve giarve approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sbejaoui @OCA-git-bot @rousseldenis @lmignon @giarve