-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] Custom fields in accounting expressions (e.g. fldp.quantity
, fld.carbon_balance
)
#584
Conversation
659cd36
to
04328ad
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
14b2cef
to
0e63372
Compare
Now that there is a default value for the debit/credit in the accumulator, we can simplify.
and prepare for custom fields
0e63372
to
4abfe17
Compare
4abfe17
to
1e2aed9
Compare
This is ready to go. I added tests and documentation. Very useful to combine quantities (say, hours) with accounting data in the same MIS report. |
fldp.quantity
)
fldp.quantity
)fldp.quantity
, fld.carbon_balance
)
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at fa23751. Thanks a lot for contributing to OCA. ❤️ |
I see that the changes added here have lost an interesting functionality (which existed in v16 and exists in v15). |
cc @sbidoul |
Ah, sorry if this caused a regression. I'll have a look in the coming days. Could you create a separate issue and if possible a little more explanation as I'm not sure I fully understand the issue. |
Of course, created and explained with a use case. #665 |
This is a very rough experiment on the Accounting Expression Processor to support expressions such as
fldp.quantity[60%]
This will read the quantity field in the same read_group as debit and credit so we can write efficient expressions on any numerical field that is available in the move-line-like table.
TODO