Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] mis_report: Added rows of accounts with no data in the comparison periods #665

Open
victoralmau opened this issue Dec 18, 2024 · 2 comments

Comments

@victoralmau
Copy link
Member

It seems to be a side effect of the changes added in #584 (it was working correctly before).

Example use case:

  • Create a mis report and use the template “Pérdidas y ganancias completo (PGCE 2008)” added by l10n_es_mis_report from OCA/l10n-spain.
  • Define the comparison mode (2023 vs 2024).
  • Click on preview/print/export
  • Rows of all accounts will be displayed (even if there is no data in 2023 and 2024 for that account).

Before the change of the initially indicated PR (or in v15) the rows of the accounts without data in the periods were not added.

Ping @sbidoul

@victoralmau victoralmau changed the title [16.0][mis_report]: Se añaden filas de cuentas sin datos en los periodos [16.0][mis_report]: Added rows of accounts with no data in the comparison periods Dec 18, 2024
@victoralmau victoralmau changed the title [16.0][mis_report]: Added rows of accounts with no data in the comparison periods [16.0] mis_report: Added rows of accounts with no data in the comparison periods Dec 18, 2024
@victoralmau
Copy link
Member Author

@sbidoul Sorry, have you had time to review this problem? I know it is related to the indicated PR but I am not very clear about the proper fix.

@sbidoul
Copy link
Member

sbidoul commented Jan 8, 2025

A fix for this is in #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants