Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX/IMP] l10n_nl_tax_statement: add past invoices in report #221

Merged
merged 2 commits into from
Oct 30, 2019
Merged

[12.0][FIX/IMP] l10n_nl_tax_statement: add past invoices in report #221

merged 2 commits into from
Oct 30, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Feb 8, 2019

Fixes #219
Forward port of #220

@CasVissers-360ERP
Copy link

@astirpe
Add invoice button seems not showing:
image

@CasVissers-360ERP
Copy link

@astirpe Can we sort on from_date? Makes more sense in tree view.

@astirpe
Copy link
Member Author

astirpe commented Mar 8, 2019

@CasVissers done! Could you check?

@hbrunn hbrunn added this to the 12.0 milestone Mar 18, 2019
@CasVissers-360ERP
Copy link

@astirpe
Possible improvements:

  • Limit invoices to last 5 year based on fiscal year end date (legal requirement)
  • When adding invoices automatically recalculate the tax statement (now a manual recalculate is necessary)
  • The unreported from date is calculate as 1 quarter I would take 1 fiscal year based on fiscal year end date

What do you think?

Of course this only takes care of new invoices, not removed invoices

@astirpe
Copy link
Member Author

astirpe commented May 1, 2019

Thank you @CasVissers , I updated the roadmap with the points you proposed.

@CasVissers-360ERP
Copy link

CasVissers-360ERP commented May 1, 2019 •
edited
Loading

@astirpe
I will approve if this point is fixed:

When adding invoices automatically recalculate the tax statement (now a manual recalculate is necessary)

I think this should be improved.

@astirpe
Copy link
Member Author

astirpe commented May 3, 2019

@CasVissers done, could you check?

CasVissers-360ERP
CasVissers-360ERP approved these changes May 3, 2019
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astirpe astirpe force-pushed the 12_fix_l10n_nl_tax_statement branch from 04a2e05 to ff902e7 Compare May 3, 2019 14:57
@astirpe astirpe force-pushed the 12_fix_l10n_nl_tax_statement branch 2 times, most recently from 8e613af to e6100a4 Compare July 29, 2019 11:57
@astirpe astirpe mentioned this pull request Jul 29, 2019
Merged
2 tasks
@astirpe astirpe force-pushed the 12_fix_l10n_nl_tax_statement branch from c069292 to 9f467b5 Compare July 30, 2019 07:46
@astirpe astirpe changed the title [12.0][FIX] l10n_nl_tax_statement: add past invoices in report [12.0][FIX/IMP] l10n_nl_tax_statement: add past invoices in report Jul 31, 2019
@astirpe
[FIX] Include past invoices in report
bcbd304 
View past invoices moves when country is not NL

[FIX] Button icon

[FIX] Sort past invoices by date

[FIX] Button icon

[FIX] Domain condition

Update roadmap

Auto-update statement lines when adding/removing past invoices

Fix failing test

Coverage

Fix calculation of past invoices in report
@astirpe astirpe force-pushed the 12_fix_l10n_nl_tax_statement branch from 61af2e0 to bcbd304 Compare July 31, 2019 09:57
@astirpe astirpe mentioned this pull request Sep 13, 2019
Merged
1 task
@astirpe astirpe mentioned this pull request Oct 10, 2019
Merged
3 tasks
@astirpe astirpe mentioned this pull request Oct 29, 2019
Merged
@StefanRijnhart
Copy link
Member

Thanks. Great module ;-)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-221-by-StefanRijnhart-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 30, 2019
@OCA-git-bot
Merge PR #221 into 12.0
cd4c84e 
Signed-off-by StefanRijnhart
@OCA-git-bot OCA-git-bot merged commit 48f9b48 into OCA:12.0 Oct 30, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 208dd60. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_fix_l10n_nl_tax_statement branch October 30, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@astirpe @CasVissers-360ERP @StefanRijnhart @OCA-git-bot @hbrunn