Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] Tax Statement: multicompany fiscal unit #238

Merged

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Sep 13, 2019

@astirpe astirpe force-pushed the 12_fix_l10n_nl_tax_statement_multicompany branch from cc2cd75 to ab8375d Compare October 30, 2019 13:48
@astirpe astirpe changed the title [12.0][WIP] Tax Statement and ICP: multicompany fiscal unit [12.0][WIP] Tax Statement: multicompany fiscal unit Nov 11, 2019
@astirpe astirpe changed the title [12.0][WIP] Tax Statement: multicompany fiscal unit [12.0][IMP] Tax Statement: multicompany fiscal unit Feb 13, 2020
@StefanRijnhart
Copy link
Member

Does this still allow people to file their NL VAT declarations for each company individually?

@astirpe
Copy link
Member Author

astirpe commented May 8, 2020

In case a group of companies are configured as belonging to a fiscal unit, I assumed that it's possible to declare only one single global tax statement for the whole group. It means that the generation of the single NL VAT declarations for each company of the group is disabled. To create an individual VAT declaration for a single company, this company should be configured as not being part of the fiscal unit. This is what the module does.

@StefanRijnhart
Copy link
Member

Ah yes, I missed that part where the user has to select the child companies explicitely. Great feature!

@StefanRijnhart StefanRijnhart added this to the 12.0 milestone May 8, 2020
@StefanRijnhart
Copy link
Member

Please review @yung-wang as this was your feature request.

@yung-wang
Copy link

tested and it works fine.

  1. Create 3 companies. Link comp 1 and comp 2 to headoffice.
  2. Create invoices in comp 1 and comp 2.

result
I get 1 total tax statement for all the companies.
In the individual companies, i get a separate ICP.

@astirpe
Copy link
Member Author

astirpe commented May 11, 2020

@yung-wang "Files changed" > "Review changes" > "Approve" ?

Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@StefanRijnhart
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-238-by-StefanRijnhart-bump-major, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit b2a41e5 into OCA:12.0 May 11, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 55011b8. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_fix_l10n_nl_tax_statement_multicompany branch May 11, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants