Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][FIX] l10n_nl_tax_statement: add past invoices in report #220

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Feb 8, 2019

Fixes #219

@astirpe astirpe force-pushed the 11_fix_l10n_nl_tax_statement branch 2 times, most recently from ef93d8c to 02f7bbe Compare July 29, 2020 11:31
View past invoices moves when country is not NL

[FIX] Sort past invoices by date

[FIX] Domain condition

Update roadmap

Fix _compute_is_invoice_basis()
@NL66278
Copy link
Contributor

NL66278 commented Dec 11, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 11, 2020
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 26, 2021
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Contributor

NL66278 commented Sep 27, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 27, 2021
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 17, 2021
@NL66278
Copy link
Contributor

NL66278 commented Apr 13, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 13, 2022
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-220-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@NL66278
Copy link
Contributor

NL66278 commented Apr 13, 2022

Most tests succeed, but when excluding the postcode api module, the test fails on a kvk authorization problem. Travis truly keeps surprising me...

@NL66278
Copy link
Contributor

NL66278 commented May 3, 2023

Needs merge of this and then rebase: #392

@NL66278
Copy link
Contributor

NL66278 commented Oct 11, 2023

@astirpe I intend to close all the 11.0 PR's, as it would be quite a lot of work to get them to pass all tests, because of all the problems. Do you agree? The alternative would be to merge them by using the github button, instead of through the OCA bot. Which would be fine by me as well.

@astirpe
Copy link
Member Author

astirpe commented Oct 11, 2023

@NL66278 no preference by my side, both are fine for me 👍 thanks!

@NL66278 NL66278 merged commit ad9e9ac into OCA:11.0 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V11] l10n_nl_tax_statement: Update of past undeclared invoices - Update of BTW statement doesn't work
5 participants