-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lomiri.lomiri-schemas: 0.1.5 -> 0.1.6 #370966
Conversation
This makes Lomiri crash on startup, in LAL's nixpkgs/pkgs/desktops/lomiri/applications/morph-browser/default.nix Lines 54 to 59 in 6df2492
I guess now's the time to look into what's going wrong in LAL, and fix it… Edit: https://gitlab.com/ubports/development/core/lomiri-app-launch/-/issues/20 |
|
|
Also note that this is a schema update, so running just the builds won't really reveal any issues. And |
Logs for ayatana-indicator-sound
|
… seems to be more evidence towards #369525 (comment)
Still dunno how reproducible this failure is for you, but I'll add a commit which should hopefully work around this. Please retry building the package afew times once it's pushed, to make sure the issue is gone for you. |
|
So… I assume the error doesn't reproduce at all for you anymore? Or if it was flaky, then you did afew rebuilds as asked to make sure this fixes it? |
I did requeue the nixpkgs-review job. That should be just a data race that disabling parallel tests solved. |
ccb0c90
to
3689b39
Compare
…relative icons for pinned apps
Spins up & talks with D-Bus in multiple tests, parallelism gets tests talking to each others' D-Bus daemons and failing when the bus they're talking to gets shut down by another test.
3689b39
to
e089450
Compare
Turns out that not every test is running well yet: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/43
104de1a
to
2256fa4
Compare
|
https://gitlab.com/ubports/development/core/lomiri-schemas/-/blob/0.1.6/ChangeLog
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.