lomiri.*: Add mesa.llvmpipeHook, re-allow affected test(s) #369525
Conversation
mesa.llvmpipeHook makes https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35 not a critical issue anymore
…low affected test(s)
github-actions
bot
added
10.rebuild-darwin: 0
|
Do you have a log for this? Builds fine for me. Also:
Where does that rebuild come from?
|
ofborg
bot
added
the
11.by: package-maintainer
Running phase: qtPreHook
@nix { "action": "setPhase", "phase": "qtPreHook" }
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/zs18wdrdgpilfg19093d1gzj1ks3k31s-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LOCALEDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/share/doc/ayatana-indicator-sound -DCMAKE_INSTALL_INFODIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/strip -DCMAKE_RANLIB=/nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/ranlib -DCMAKE_AR=/nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1 -DENABLE_TESTS:BOOL=TRUE -DENABLE_LOMIRI_FEATURES:BOOL=TRUE -DGSETTINGS_LOCALINSTALL:BOOL=TRUE -DGSETTINGS_COMPILE:BOOL=TRUE
-- The C compiler identification is GNU 14.2.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /nix/store/0d4m43yp69lrm8imxbqgl9zxjwwz52jw-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
-- Found Vala: /nix/store/v2kdxvkp36r7p9wagxbfm3qzhsqkcfyv-vala-0.56.17/bin/valac (found suitable version "0.56.17", minimum required is "0.20")
-- Checking for modules 'libpulse-mainloop-glib>=0.9.19;glib-2.0>=2.32;gio-unix-2.0>=2.25.13'
-- Found libpulse-mainloop-glib, version 17.0
-- Found glib-2.0, version 2.82.1
-- Found gio-unix-2.0, version 2.82.1
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
-- Checking for modules 'gee-0.8;gio-2.0>=2.25.13;gio-unix-2.0;gthread-2.0;libxml-2.0;libnotify;accountsservice;libayatana-common;liblomiri-api>=0.1.1;lomiri-schemas'
-- Found gee-0.8, version 0.20.6
-- Found gio-2.0, version 2.82.1
-- Found gio-unix-2.0, version 2.82.1
-- Found gthread-2.0, version 2.82.1
-- Found libxml-2.0, version 2.13.5
-- Found libnotify, version 0.8.3
-- Found accountsservice, version 23.13.9
-- Found libayatana-common, version 0.9.10
-- Found liblomiri-api, version 0.2.0
-- Found lomiri-schemas, version 0.1.5
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
-- Checking for module 'gobject-introspection-1.0'
-- Found gobject-introspection-1.0, version 1.82.0
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
-- Found Gettext: /nix/store/9a46kza0vbb4vdsdmpzbdc7f31y7hs0i-gettext-0.22.5/bin/msgmerge (found version "0.22.5")
-- GSettings schemas will be installed locally.
-- GSettings schemas will be installed into /nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/share/glib-2.0/schemas/
-- Installed GSettings schemas will be compiled.
-- Checking for module 'systemd'
-- Found systemd, version 256
-- /nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1/lib/systemd/user is the systemd user unit file install dir
-- Found Intltool: /nix/store/5kg3f63gkpwgdawnv9hvygcdis4arjvg-intltool-0.51.0/bin/intltool-update (found version "0.51.0")
-- Checking for module 'dbustest-1>=15.04.0'
-- Found dbustest-1, version 19.04.1
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found GTest: /nix/store/jjk5d24nfk0z87cg78cv5mzy2yj5z2fa-gtest-1.15.2-dev/lib/cmake/GTest/GTestConfig.cmake (found version "1.15.2")
-- Checking for module 'gtest'
-- Found gtest, version 1.15.2
�[0m-- Using GTest v1.15.2 (parsed from pkg-config)�[0m
-- Checking for module 'libgmenuharness'
-- Found libgmenuharness, version 0.1.4
-- Checking for module 'libqtdbustest-1'
-- Found libqtdbustest-1, version 1
-- Checking for module 'libqtdbusmock-1'
-- Found libqtdbusmock-1, version 1
-- Checking for modules 'glib-2.0>=2.26;gio-2.0>=2.26'
-- Found glib-2.0, version 2.82.1
-- Found gio-2.0, version 2.82.1
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
Package sysprof-capture-4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sysprof-capture-4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'sysprof-capture-4', required by 'glib-2.0', not found
-- Install prefix: /nix/store/ryfaihr145na72pv5khy0xdw1waglaak-ayatana-indicator-sound-24.5.1
-- Unit tests: TRUE
-- Build with -Werror: OFF
-- Build with Lomiri features: TRUE
-- Configuring done (22.8s)
-- Generating done (1.9s)
�[33mCMake Warning:
Manually-specified variables were not used by the project:
|
wegank
added
the
12.approvals: 1
|
I can't reproduce this locally - neither on master, nor in the merged state that Is this failure reproducible for you, or flaky? If this is reproducible, or not too flaky, and assuming this is maybe an issue with DBus getting spun up & shut down by multiple tests with unfortunate timing, does setting |
|
I'll queue this PR review again and see if it happens again |
|
@ofborg test lomiri |
|
I think OfBorg is dead for now: https://discourse.nixos.org/t/ofborg-migration-very-soon/58064/1 |
|
Previously, we were unable to run various tests because
lomiri-ui-toolkitonly mostly works without an OpenGL context: Anything that would initialiseShapeMaterialwould cause a segfault of the process, due toQOpenGLContext::currentContext()returningNULLand missing handling for this situation: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35With
mesa.llvmpipeHookintroduced in b0a82fe, we can provide a software OpenGL setup to the tests. This allows us to stop patching out those tests. 🥳Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.