Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardnotes: 3.181.23 -> 3.195.13 #365265

Merged
merged 1 commit into from
Dec 24, 2024
Merged

standardnotes: 3.181.23 -> 3.195.13 #365265

merged 1 commit into from
Dec 24, 2024

Conversation

LeSuisse
Copy link
Contributor

Closes #293270
Closes #360697

"Changelog":
standardnotes/app@@standardnotes/[email protected]...@standardnotes/[email protected]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/) (UI starts)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 14, 2024
@ofborg ofborg bot requested review from squalus, chuangzhu and M-Gregoire December 15, 2024 11:16
Samasaur1
Samasaur1 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Samasaur1 Samasaur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know anything about this package but it builds fine for me on x86_64-linux

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 19, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365265

x86_64-linux

✅ 1 package built:
  • standardnotes

aarch64-linux

❌ 1 package failed to build:
  • standardnotes

@GaetanLepage
Copy link
Contributor

Fails on aarch64-linux with:

Running phase: unpackPhase
unpacking source archive /nix/store/84xcxpv62ak3njl9jd9q24ik0b6x523b-standard-notes-3.195.13-linux-arm64.deb
source root is root
setting SOURCE_DATE_EPOCH to timestamp 1731261280 of file root/usr/share/doc/standard-notes/changelog.gz
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: installPhase
node:fs:573
  return binding.open(
                 ^

Error: ENOENT: no such file or directory, open '/nix/store/87qflxscgqbpa3vklzcwbk8aa3z49h21-standardnotes-3.195.13/share/standardnotes/app.asar.unpacked/node_modules/microtime/build>
    at Object.openSync (node:fs:573:18)
    at Object.readFileSync (node:fs:452:35)
    at module.exports.readFileSync (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/lib/disk.js:110:17)
    at module.exports.extractAll (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/lib/asar.js:204:28)
    at Command.<anonymous> (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/bin/asar.js:72:10)
    at Command.listener [as _actionHandler] (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/node_modules/commander/index.js:413:31)
    at Command._parseCommand (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/node_modules/commander/index.js:914:14)
    at Command._dispatchSubcommand (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/node_modules/commander/index.js:865:18)
    at Command._parseCommand (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/node_modules/commander/index.js:882:12)
    at Command.parse (/nix/store/hnhcq58hs99sa55almqy3vc3c1w9vjxi-electron-asar-3.2.4/lib/node_modules/@electron/asar/node_modules/commander/index.js:717:10) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/nix/store/87qflxscgqbpa3vklzcwbk8aa3z49h21-standardnotes-3.195.13/share/standardnotes/app.asar.unpacked/node_modules/microtime/build/node_gyp_bins/python3'
}

Node.js v20.18.1

@LeSuisse LeSuisse force-pushed the standardnotes-3.195.13 branch from 8bf256a to 1c29bf1 Compare December 24, 2024 15:04
@LeSuisse
Copy link
Contributor Author

Build should now be fixed but I cannot test the app on aarch64 right now.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365265

x86_64-linux

✅ 1 package built:
  • standardnotes

aarch64-linux

✅ 1 package built:
  • standardnotes

GaetanLepage
GaetanLepage approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@GaetanLepage GaetanLepage merged commit ec2c7c6 into NixOS:master Dec 24, 2024
23 of 24 checks passed
@LeSuisse LeSuisse deleted the standardnotes-3.195.13 branch December 24, 2024 15:43
@baalajimaestro
Copy link

This should be backported to 24.11, the changes between 3.181.23 -> 3.195.13 is not breaking changes, and in fact fixes the blank white window bug mentioned on the issue #360697 (comment)

@GaetanLepage GaetanLepage added the backport release-24.11 Backport PR automatically label Dec 26, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 26, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 26, 2024
Merged
1 task
@GaetanLepage
Copy link
Contributor

This should be backported to 24.11, the changes between 3.181.23 -> 3.195.13 is not breaking changes, and in fact fixes the blank white window bug mentioned on the issue #360697 (comment)

Sure, done and merged.

@wegank wegank mentioned this pull request Dec 31, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@Samasaur1 Samasaur1 Samasaur1 approved these changes

@squalus squalus Awaiting requested review from squalus

@chuangzhu chuangzhu Awaiting requested review from chuangzhu

@M-Gregoire M-Gregoire Awaiting requested review from M-Gregoire

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: standardnotes 3.181.23 → 3.195.13 Update request: standardnotes 3.181.23 → 3.191.4
5 participants
@LeSuisse @GaetanLepage @baalajimaestro @Samasaur1 @wegank