Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardnotes: 3.181.23 -> 3.191.4 #296421

Closed
wants to merge 1 commit into from

Conversation

baalajimaestro
Copy link

@baalajimaestro baalajimaestro commented Mar 16, 2024

Description of changes

https://github.com/standardnotes/app/releases/tag/%40standardnotes%2Fdesktop%403.191.4
Upgraded standardnotes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 16, 2024
@baalajimaestro
Copy link
Author

Closes #293270

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 16, 2024
@JohnRTitor
Copy link
Contributor

Since v3.194.0 is available now, can you update the PR accordingly?

@pbsbot
Copy link

pbsbot commented Jun 11, 2024

Result of nixpkgs-review pr 296421 run on x86_64-linux 1

1 package failed to build:
  • standardnotes
standardnotes> building '/nix/store/939lj1dfss2k4pg91bhwfmzf022hmxsd-standardnotes-3.191.4.drv'
standardnotes> Running phase: unpackPhase
standardnotes> Running phase: patchPhase
standardnotes> Running phase: updateAutotoolsGnuConfigScriptsPhase
standardnotes> Updating Autotools / GNU config script to a newer upstream version: ./opt/Standard
standardnotes> Updating Autotools / GNU config script to a newer upstream version: Notes/resources/app.asar.unpacked/node_modules/sqlite3/build/Release/obj/gen/sqlite-autoconf-3410100/config.sub
standardnotes> cp: cannot create regular file 'Notes/resources/app.asar.unpacked/node_modules/sqlite3/build/Release/obj/gen/sqlite-autoconf-3410100/config.sub': No such file or directory

@baalajimaestro
Copy link
Author

Since v3.194.0 is available now, can you update the PR accordingly?

The problem is, i am not sure how to cleanly build it, it fails at the configuring auto tools phase, which i was able to override and no-op, but im sure thats not the right way, and there is something else thats triggering the autotools phase.

@baalajimaestro
Copy link
Author

  standardnotes_overlay = self: super: {
    standardnotes = super.standardnotes.overrideAttrs (oldAttrs: rec {
      version = "3.194.0";
      src = super.fetchurl {
        url = "https://github.com/standardnotes/app/releases/download/%40standardnotes%2Fdesktop%403.194.0/standard-notes-3.194.0-linux-amd64.deb";
        sha512 = "sha512-RLeDqkeHtSW6Tk9P8qZvXtB92joxo6caOUVx1bPjKn+b8Wvnfs4lE0jjldQlOaHXVs20luI+dMu1xRyQCZU6gA==";
      };
      updateAutotoolsGnuConfigScriptsPhase = ":";
      installPhase = ''
        runHook preInstall

        mkdir -p $out/bin $out/share/standardnotes
        cp -R usr/share/{applications,icons} $out/share
        cp -R opt/Standard\ Notes/resources/app.asar $out/share/standardnotes/

        makeWrapper ${pkgs.electron_27}/bin/electron $out/bin/standardnotes \
          --add-flags $out/share/standardnotes/app.asar \
          --prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ pkgs.libsecret pkgs.stdenv.cc.cc.lib ]}

        ${pkgs.desktop-file-utils}/bin/desktop-file-install --dir $out/share/applications \
          --set-key Exec --set-value standardnotes usr/share/applications/standard-notes.desktop

        runHook postInstall
      '';

    });
  };

Overlay for anyone who wishes to update theirs, until this is sorted out properly

@pbsds pbsds added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 16, 2024
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 11, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 11, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@wegank
Copy link
Member

wegank commented Dec 31, 2024

Superseded by #365265.

@wegank wegank closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_changes (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants