Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsStatic.haskellPackages: run checks by default #342094

Open
wants to merge 5 commits into
base: haskell-updates
Choose a base branch
from
+32 −1
Open

pkgsStatic.haskellPackages: run checks by default #342094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30a27a0
pkgsStatic.haskellPackages: run checks by default
wolfgangwalther Sep 15, 2024
7cd3f1c
pkgsStatic.haskellPackages.hashable: disable checks
wolfgangwalther Sep 15, 2024
adeb1ea
pkgsStatic.haskellPackages.unliftio: disable checks
wolfgangwalther Dec 21, 2024
67c5c2a
pkgsStatic.haskellPackages.infer-license: disable checks
wolfgangwalther Dec 21, 2024
7a63cb9
pkgsStatic.haskellPackages.interpolate: disable checks
wolfgangwalther Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions pkgs/development/haskell-modules/configuration-common.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2261,6 +2261,37 @@ self: super: {
# Too strict bound on hspec (<2.11)
utf8-light = doJailbreak super.utf8-light;

# Fails to build in pkgsStatic with:
# Preprocessing test suite 'hashable-tests' for hashable-1.4.4.0..
# Mmap.hsc: In function ‘_hsc2hs_test13’:
# Mmap.hsc:54:20: error: storage size of ‘test_array’ isn’t constant
# compilation failed
hashable = dontCheckIf pkgs.stdenv.hostPlatform.isStatic super.hashable;
Comment on lines +2265 to +2269
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether that's a problem with hashable, hsc2hs or nixpkgs. Any ideas?


# Fails to build in pkgsStatic with:
# Building test suite 'unliftio-spec' for unliftio-0.2.25.0..
# ghc: could not execute: hspec-discover
#
# Because of this in Spec.hs:
# {-# OPTIONS_GHC -F -pgmF hspec-discover #-}
unliftio = dontCheckIf pkgs.stdenv.hostPlatform.isStatic super.unliftio;

# Fails to build in pkgsStatic with:
# Building test suite 'spec' for infer-license-0.2.0..
# ghc: could not execute: hspec-discover
#
# Because of this in Spec.hs:
# {-# OPTIONS_GHC -fforce-recomp -F -pgmF hspec-discover #-}
infer-license = dontCheckIf pkgs.stdenv.hostPlatform.isStatic super.infer-license;

# Fails to build in pkgsStatic with:
# Building test suite 'spec' for interpolate-0.2.1..
# ghc: could not execute: hspec-discover
#
# Because of this in Spec.hs:
# {-# OPTIONS_GHC -F -pgmF hspec-discover #-}
interpolate = dontCheckIf pkgs.stdenv.hostPlatform.isStatic super.interpolate;

# BSON defaults to requiring network instead of network-bsd which is
# required nowadays: https://github.com/mongodb-haskell/bson/issues/26
bson = appendConfigureFlag "-f-_old_network" (super.bson.override {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/haskell-modules/generic-builder.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ in
, buildFlags ? []
, haddockFlags ? []
, description ? null
, doCheck ? !isCross
, doCheck ? stdenv.buildPlatform.canExecute stdenv.hostPlatform
, doBenchmark ? false
, doHoogle ? true
, doHaddockQuickjump ? doHoogle
Expand Down
Loading