pkgsStatic.haskellPackages: run checks by default #342094
Conversation
wolfgangwalther
requested review from
sternenseemann and
maralorn
as code owners
| # Preprocessing test suite 'hashable-tests' for hashable-1.4.4.0.. | ||
| # Mmap.hsc: In function ‘_hsc2hs_test13’: | ||
| # Mmap.hsc:54:20: error: storage size of ‘test_array’ isn’t constant | ||
| # compilation failed | ||
| hashable = dontCheckIf pkgs.stdenv.hostPlatform.isStatic super.hashable; |
There was a problem hiding this comment.
I don't know whether that's a problem with hashable, hsc2hs or nixpkgs. Any ideas?
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build pkgsStatic.cachix |
|
@ofborg build pkgsStatic.haskellPackages.cabal2nix |
wegank
added
the
2.status: merge conflict
wolfgangwalther
force-pushed
the
haskell-check-static
branch
from
3c13f22 to
9f7663b
Compare
wolfgangwalther
removed
the
2.status: merge conflict
The default for doCheck is meant to disable tests, when they can't be executed in cross environments. However, pkgsStatic and some other package sets are technically implemented as cross, even though the binaries can be executed just fine. Using canExecute is a much better check for this, thus enabling tests on pkgsStatic by default.
wolfgangwalther
force-pushed
the
haskell-check-static
branch
from
9f7663b to
7cd3f1c
Compare
This fails to build on master right now as well, because
On my way t building that I got the same build failure for 3 packages in a row - and I assume there are going to be many more: This is because of code similar to this: https://github.com/Vlix/http-types/blob/master/test/Spec.hs#L1C2-L1C44 I'm not sure, yet, whether that's because hspec-discover is prefixed somehow or whether it's not passed as nativeBuildInput or ... I don't know. In any case, this needs a generic solution. |
It seems like the generic-builder doesn't support hspec has hspec-discover as |
Description of changes
The default for
doCheckis meant to disable tests, when they can't be executed in cross environments. However,pkgsStaticand some other package sets are technically implemented as cross, even though the binaries can be executed just fine. UsingcanExecuteis a much better check for this, thus enabling test onpkgsStaticby default.I found one package already which has broken tests for
pkgsStaticonly, thus I disabled them. There are very likely many more, but we'd need to build many more packages to find out...Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.