Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framac: Update to GTK 3 #155173

Merged
merged 1 commit into from
Jan 23, 2022
Merged

framac: Update to GTK 3 #155173

merged 1 commit into from
Jan 23, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jan 16, 2022 •
edited
Loading

Motivation for this change

lablgtk2 depends on libglade, which is being removed. This will result in partial gui since ocamlgraph has not been ported to GTK 3.

The GUI will also not work on Mac:
https://git.frama-c.com/pub/frama-c/-/blob/a0aa5c1d3a66f05f2b43156c2d5c0eca8316124d/opam/opam#L115

cc @thoughtpolice @amiddelk @piegamesde

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar
framac: Update to GTK 3
701dcec 
lablgtk2 depends on libglade, which is being removed.
This will result in partial gui since ocamlgraph has not been ported to GTK 3:
backtracking/ocamlgraph#87
@ofborg ofborg bot requested review from thoughtpolice and amiddelk January 16, 2022 02:30
@piegamesde piegamesde mentioned this pull request Jan 16, 2022
Merged
13 tasks
@piegamesde piegamesde merged commit f25b876 into NixOS:master Jan 23, 2022
@jtojnar jtojnar deleted the framac-gtk3 branch January 24, 2022 00:37
@vbgl
Copy link
Contributor

vbgl commented Jan 26, 2022

Do you know what are the missing features of the GTK3 interface? The call-graph view is missing. Anything else?

Are there any new features brought by this PR or is it only regressions?

@jtojnar
Copy link
Member Author

jtojnar commented Jan 26, 2022

https://git.frama-c.com/search?search=DGRAPH_MODULE&group_id=398&project_id=780&scope=&search_code=true&snippets=false&repository_ref=a0aa5c1d3a66f05f2b43156c2d5c0eca8316124d&nav_source=navbar
https://git.frama-c.com/search?search=Dgraph_helper&group_id=398&project_id=780&scope=&search_code=true&snippets=false&repository_ref=a0aa5c1d3a66f05f2b43156c2d5c0eca8316124d&nav_source=navbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@amiddelk amiddelk Awaiting requested review from amiddelk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtojnar @vbgl @piegamesde