Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove some libglade dependents #155061

Merged
merged 19 commits into from
Feb 1, 2022
Merged

treewide: remove some libglade dependents #155061

merged 19 commits into from
Feb 1, 2022

Conversation

piegamesde
Copy link
Member

@piegamesde piegamesde commented Jan 15, 2022 •
edited
Loading

Motivation for this change
  • A list of packages that grep for "python2" #148779 Python 2 has reached its end of life and packages depending on it shall be patched or removed
  • libglade depends on Python 2. The functionality of libglade itself has been subsumed as "Builder" in Gtk3. Gtk2 is end of life as well, btw.
  • Dropped a some packages that depend on libglade, and their transitive dependencies.
  • Notable drops:
    • libgtkmm, the C++ bindings, and all applications using it
    • libgksu and gksu
    • gtk-sharp and thus all Gtk2 applications written in C#
    • lablgtk and all Gtk2 application written in OCaml
    • Various random applications ("leaf packages")

Some packages are fixed instead of being removed. Some more can be, I'll replace the drop commits with fix commits as we go. Help welcome (see #155173 for example).

This PR is still a WIP, but it has mostly reached its final form. Commits that are incomplete are marked with TODO in the message.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@piegamesde piegamesde force-pushed the gnome branch 2 times, most recently from 8e3540f to e824a71 Compare January 15, 2022 22:26
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 15, 2022
@mweinelt mweinelt changed the title WIP WIP: treewide: remove libglade Jan 15, 2022
@piegamesde piegamesde force-pushed the gnome branch 3 times, most recently from 86c5488 to 4b2f1a3 Compare January 16, 2022 00:14
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 16, 2022
@piegamesde piegamesde force-pushed the gnome branch 2 times, most recently from 50c0ab9 to e9afb00 Compare January 16, 2022 01:17
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 16, 2022
@github-actions github-actions bot added the 6.topic: xfce The Xfce Desktop Environment label Jan 16, 2022
@piegamesde
python2Packages.{pygtk,pyGtkGlade}: remove libglade support
724822a
@piegamesde
yarssr: drop
fb16343
@piegamesde
perlPackages.Gtk2GladeXML: drop
a7e5835
@piegamesde
pbis: remove comment referencing libglade
f6d2cea
@piegamesde
tilp2: drop
5ffbf9e 
While tilp2's libglade dependency is optional, it still has a hard dependency
on it via gfm
@piegamesde
xfce: drop libglade
0f5180e
@piegamesde
monodevelop: drop
768672d 
It was marked as broken for some time now anyways
@piegamesde
pdfmod: drop
6aa8521
@piegamesde
gnome-sharp: drop
dcc2473
@piegamesde
gtk-sharp*: remove old optional Gnome2 dependencies
48e2f68 
They were marked as optional with `dependency ? null`, however they
were references unconditionally in the `buildInputs`. I don't know how
all of this ever worked, but it's removed anyways now.
@piegamesde
timekeeper: drop
34af921
@piegamesde
libglademm: drop
5f192c0
@piegamesde
guile-gnome: drop
4850d0e
@piegamesde
obconf: drop
82c39d6
@piegamesde
nixos/modules/programs/spacefm: remove gksu dependency
405b157
@piegamesde
gksu: drop
b16e5d2
@piegamesde
libgksu: drop
dfbe108
@piegamesde
gfm: drop
9a2a3d0 
It does not appear to have an attribute that references it anymore?
(Not sure though, that name's hard to grep for)
@piegamesde piegamesde force-pushed the gnome branch 2 times, most recently from 6ac37b0 to 9a2a3d0 Compare January 29, 2022 17:10
@piegamesde
Copy link
Member Author

@dasj19 I rebased on master and only got conflicts for the tomboy commit. I don't know where your problems with the monodevelop file come from.

dasj19
dasj19 approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it builds. I guess the error with the monodevelop file was from the way I was applying the patch.

But nevermind, everything works now

@mweinelt
Copy link
Member

mweinelt commented Feb 1, 2022

Result of nixpkgs-review pr 155061 run on x86_64-linux 1

1 package marked as broken and skipped:
  • supertux-editor
2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
2 packages failed to build:
  • picoscope
  • snapdragon-profiler
12 packages built:
  • appindicator-sharp
  • bless
  • dotnetPackages.MonoAddins
  • gio-sharp
  • gtk-sharp-2_0
  • gtk-sharp-3_0
  • gtk-sharp-beans
  • hyena
  • mono-addins
  • notify-sharp
  • sparkleshare
  • webkit2-sharp

@mweinelt mweinelt merged commit 778d148 into NixOS:master Feb 1, 2022
@SFrijters SFrijters mentioned this pull request Feb 2, 2022
Merged
13 tasks
@piegamesde piegamesde mentioned this pull request Feb 3, 2022
Closed
13 tasks
@WolfangAukang WolfangAukang mentioned this pull request Apr 26, 2022
Merged
13 tasks
@pennae pennae mentioned this pull request Feb 24, 2023
Closed
@myclevorname myclevorname mentioned this pull request Jul 17, 2024
Open
@myclevorname myclevorname mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mindavi Mindavi Mindavi left review comments

@dasj19 dasj19 dasj19 approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@piegamesde @mweinelt @bburdette @vbgl @reckenrode @dasj19 @bendlas @Mindavi @cole-h