This repository has been archived by the owner on May 6, 2024. It is now read-only.
Secret service #23
Merged
Secret service #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlogozzo
suggested changes
Sep 10, 2023
|
Just tested flatpak - it works, only |
3 tasks
|
Will merge and release when I get home |
nlogozzo
approved these changes
Sep 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Closes #22
Uses Ace4896.DBus.Services.Secrets instead of libsecret.
Unfortunately there are some bugs in this package, as workaround an item attribute (
applicationwith app ID as the value) is used to determine which item in keyring contains the password we need. Not a big deal really, but I find it less straightforward than using item label.One more
unusual(not really unusual: I noticed I have the same thing with items created by other apps) thing is that the data seems to be saved to keyring in some odd way that a password itself isn't shows in an entry in Seahorse. But I tried to print it out and so I'm totally sure a password is saved correctly, it's not empty. Reading a password that was manually typed in Seahorse also works, so it's still possible to migrate a Parabolic's keyring.Parabolic unsandboxed was successfully tested, will test Flatpak and Snap later.