Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Aura with secret service support #570

Merged
merged 25 commits into from
Sep 10, 2023
Merged

Updated Aura with secret service support #570

merged 25 commits into from
Sep 10, 2023

Conversation

fsobolev
Copy link
Member

@fsobolev fsobolev commented Sep 6, 2023

Closes #569
Depends on NickvisionApps/Aura#18
Depends in NickvisionApps/Aura#23

TODO:

  • Update csproj to reference new version of Aura
  • Fix creating Parabolic keyring when keyring is locked
  • Update po(t)

@fsobolev fsobolev marked this pull request as ready for review September 7, 2023 17:56
@fsobolev
Copy link
Member Author

fsobolev commented Sep 7, 2023

Forgot to update flatpak sources, and also need to check whether flatpak requires any new permissions, will build locally to test

@nlogozzo
Copy link
Member

nlogozzo commented Sep 7, 2023

Forgot to update flatpak sources, and also need to check whether flatpak requires any new permissions, will build locally to test

Probably need "--talk-name=org.freedesktop.secrets"

@fsobolev fsobolev requested review from nlogozzo and removed request for nlogozzo September 7, 2023 19:54
Copy link
Member

@nlogozzo nlogozzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question: What happens to Keyrings created with old Parabolic and then opened in this new Parabolic? Will they still be asked for the password everytime to open the Keyring? Or the first time they open the Keyring it will get stored in libsecret and they won't be asked again?

flatpak/org.nickvision.tubeconverter.json Outdated Show resolved Hide resolved
@fsobolev
Copy link
Member Author

fsobolev commented Sep 8, 2023

Another question: What happens to Keyrings created with old Parabolic and then opened in this new Parabolic? Will they still be asked for the password everytime to open the Keyring? Or the first time they open the Keyring it will get stored in libsecret and they won't be asked again?

I didn't test it myself, but I expect that a new random password will be generated and saved in system keyring (only at first start) but because it will not match the keyring's password the user will be prompted every time. There are 2 ways to migrate: either remove keyring and create new one, or save the keyring passord to system keyring, this can be easily done using Seahorse, I want to write a small guide as soon as the beta releases.

EDIT: Tested, works just like I said

@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2023

Button to Docs in PasswordDialog:
image

@nlogozzo nlogozzo self-requested a review September 9, 2023 03:18
@nlogozzo
Copy link
Member

nlogozzo commented Sep 9, 2023

@soumyaDghosh is there anything that needs to be added to the snap yml for libsecret use?

@soumyaDghosh
Copy link
Member

It's in gnome-sdk

@fsobolev
Copy link
Member Author

fsobolev commented Sep 9, 2023

It's in gnome-sdk

Please check manually that it works (simply enabling keyring is enough), there's some weird thing in sandboxed environment so we have to build libsecret with -Dgcrypt=false even tho libsecret is in GNOME Platform in flatpak too.

And pasword-manager-service plug seems to be needed anyway.

@fsobolev
Copy link
Member Author

fsobolev commented Sep 9, 2023

Please check manually that it works (simply enabling keyring is enough), there's some weird thing in sandboxed environment so we have to build libsecret with -Dgcrypt=false even tho libsecret is in GNOME Platform in flatpak too.

And pasword-manager-service plug seems to be needed anyway.

Just like I thought, it doesn't work in Snap even with password-manager-service, libsecret should be built with -Dgcrypt=false

Nvm for now, I found a nuget package to avoid using libsecret, let's see how well it works

@fsobolev fsobolev changed the title Updated Aura with libsecret support Updated Aura with secret service support Sep 10, 2023
@nlogozzo nlogozzo self-requested a review September 10, 2023 21:20
@nlogozzo nlogozzo merged commit 6b9a6b5 into main Sep 10, 2023
@nlogozzo nlogozzo deleted the libsecret branch September 10, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Aura to 2023.9.1
3 participants