Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix coverage report publishing #1597

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

Unique-Divine
Copy link
Member

Purpose

The codecov reports stopped being published and used to work in prior commits like d0bc884 and tag v0.21.8.

This PR is intended to restore the functionality for publishing coverage reports (I think it's simply removing a flag).

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1597 (2c5e84a) into master (0f2169e) will decrease coverage by 0.05%.
Report is 10 commits behind head on master.
The diff coverage is 78.85%.

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
- Coverage   70.77%   70.73%   -0.05%     
==========================================
  Files         180      181       +1     
  Lines       14786    14917     +131     
==========================================
+ Hits        10465    10551      +86     
- Misses       3645     3677      +32     
- Partials      676      689      +13     
Files Changed Coverage
x/common/asset/pair.go ø
x/epochs/types/identifier.go ø
x/perp/v2/keeper/calc.go ø
x/perp/v2/keeper/twap.go ø
x/perp/v2/module/abci.go 28.57%
x/perp/v2/module/genesis.go 62.50%
x/perp/v2/keeper/dnr.go 67.44%
x/perp/v2/keeper/clearing_house.go 75.00%
x/perp/v2/keeper/grpc_query.go 77.77%
x/perp/v2/keeper/amm.go 78.57%
... and 13 more

@Unique-Divine Unique-Divine marked this pull request as ready for review September 21, 2023 18:55
@Unique-Divine Unique-Divine requested a review from a team as a code owner September 21, 2023 18:55
@Unique-Divine Unique-Divine force-pushed the realu/ci-coverage-not-reporting branch from e28ae00 to 72094e8 Compare September 21, 2023 18:57
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Unique-Divine Unique-Divine merged commit 65eb84f into master Sep 22, 2023
16 of 17 checks passed
@Unique-Divine Unique-Divine deleted the realu/ci-coverage-not-reporting branch September 22, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants