Skip to content

Commit

Permalink
ci: fix coverage report publishing (#1597)
Browse files Browse the repository at this point in the history
* ci: try removing flags to make reports publish

* ci: disable verbose flag #wip

* chore: rn gofumpt formatter cause change and run CI

* refactor(test.mk): add comment to NOTE the issue with using the verbose flag

* kick the CI to make it run
  • Loading branch information
Unique-Divine authored Sep 22, 2023
1 parent 2ce598d commit 65eb84f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@ name: Integration tests

on:
workflow_dispatch: # Runs on manual calls
schedule:
schedule:
- cron: "0 0 * * *" # Runs automatically every day
pull_request:
# paths makes the action run only when the given paths are changed
paths: ["**.go", "**.proto", "go.mod", "go.sum"]

# Allow concurrent runs on main/release branches but isolates other branches
# Allow concurrent runs on main/release branches but isolates other branches
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
cancel-in-progress: ${{ ! (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release/')) }}

jobs:
integration-tests:
# Job that runs all tests and publishes code coverage reports.
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
Expand Down
13 changes: 7 additions & 6 deletions contrib/make/test.mk
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
###############################################################################
### Tests ###
###############################################################################
#########################################################################
# Tests
#########################################################################

PACKAGES_NOSIMULATION = ${shell go list ./... | grep -v simapp}

# Used for CI by Codecov
.PHONY: test-coverage
test-coverage:
go test ./... -v $(PACKAGES_NOSIMULATION) -short \
go test ./... $(PACKAGES_NOSIMULATION) -short \
-coverprofile=coverage.txt \
-covermode=atomic \
-race | grep -v "no test" | grep -v "no statement"

# NOTE: Using the verbose flag breaks the coverage reporting in CI.
# Used for CI by Codecov
.PHONY: test-coverage-integration
test-coverage-integration:
go test ./... -v $(PACKAGES_NOSIMULATION) \
go test ./... \
-coverprofile=coverage.txt \
-covermode=atomic \
-race | grep -v "no test" | grep -v "no statement"
Expand Down
1 change: 0 additions & 1 deletion x/perp/v2/keeper/clearing_house.go
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,6 @@ func (k Keeper) PartialClose(
pair asset.Pair,
traderAddr sdk.AccAddress,
sizeAmt sdk.Dec, // unsigned

) (*types.PositionResp, error) {
market, err := k.GetMarket(ctx, pair)
if err != nil {
Expand Down

0 comments on commit 65eb84f

Please sign in to comment.