Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Order Styling - Part 3 #2319

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Load Order Styling - Part 3 #2319

merged 7 commits into from
Nov 27, 2024

Conversation

insomnious
Copy link
Collaborator

Part of #2277

  • Styling tweaks and fixes for ComboBox and CheckBox
  • Alert hide and show

@insomnious insomnious self-assigned this Nov 27, 2024
@insomnious insomnious marked this pull request as ready for review November 27, 2024 16:09
Comment on lines +69 to +70
Title="{Binding InfoAlertTitle}"
Body="{Binding InfoAlertMessage}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to remember to change these to Code behind bindings

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We will need more bindings as Laurence has added more tooltips etc so will move to code behind when we go through and tidy up the data. Next week now. Also need to refactor all the styling out into files as well.

Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here!

@Al12rs Al12rs merged commit 44b9f73 into main Nov 27, 2024
14 of 15 checks passed
@Al12rs Al12rs deleted the load-order-styling branch November 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants