MCS-1983 Replaced old webenabled scenes with Eval 7 scenes #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-38
to
+39
| INTERACTIVE_ASYMMETRIC_TOOL_USE = ( | ||
| INTERACTIVE_ASYMMETRIC_TOOL = ( |
There was a problem hiding this comment.
I had to rename a few of these to align with the Eval 7 files, but kept the old names as backups.
Comment on lines
+375
to
+379
| # Remove "eval_7_" from the scene name if it's present. | ||
| scene_type = scene_type.replace('EVAL_7_', '') | ||
| # Rename passive_agents to passive_agent for simplicity, because I'm | ||
| # apparently inconsistent with our naming conventions (sorry). | ||
| scene_type = scene_type.replace('PASSIVE_AGENTS_', 'PASSIVE_AGENT_') |
There was a problem hiding this comment.
This seemed easier than renaming all of the Eval 7 files.
ThomasSchellenbergNextCentury
requested review from
rartiss55,
phile-caci and
NDCACI
NDCACI
approved these changes
Dec 14, 2023
|
@NDCACI , I got an error launching this.. are you seeing that too or am I all messed up? |
|
I commented out the old task names that where changed and reassigned to the new EVAL 7 names, they were causing enumeration errors. |
phile-caci
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.