Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RotationNR fails to maintain consistency when converted to rotation angles and back #29

Open
madhephaestus opened this issue Dec 19, 2016 · 1 comment
Open

RotationNR fails to maintain consistency when converted to rotation angles and back #29

madhephaestus opened this issue Dec 19, 2016 · 1 comment
Labels
bug

Comments

@madhephaestus
Copy link
Member

madhephaestus commented Dec 19, 2016 •
edited
Loading

RotationNR sometimes produces invalid rotations after a conversion from rotation angles and back again. The failure could be in the quaternion conversion, the rotation angle conversion or maybe a separate bug in each. Additional unit test cases could and should be added so all conversion space and types of absolute rotations should be checked.
madhephaestus added a commit that referenced this issue Dec 19, 2016
@madhephaestus
Unit test to demonstrate #29
d214e21
madhephaestus added a commit that referenced this issue Dec 19, 2016
@madhephaestus
tighting up the unit test for #29
caa127f
madhephaestus added a commit that referenced this issue Dec 19, 2016
@madhephaestus
More explicate tests with print outs to show diviation #29
ef15eed
@madhephaestus madhephaestus changed the title RotationNR fails the holonomic conversion RotationNR fails to maintain consistency when converted to rotation angles and back Dec 19, 2016
madhephaestus added a commit that referenced this issue Dec 20, 2016
@madhephaestus
This produces results that are either accurate or 180 complement of the
487f90c 
angle. #29
@madhephaestus madhephaestus reopened this Dec 22, 2016
@madhephaestus
Copy link
Member Author

It would seem the new library is not producing rotation angles from quaturnions in a way that is API compatible with the previous system.

madhephaestus added a commit that referenced this issue Dec 29, 2016
@madhephaestus
Updated the RotationNR class
6cd40df 
This class now uses the internal representation of the rotation using
the apache math3 Rotation class. #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madhephaestus