Fixes and improvements to powerMonitor #445
Open
+370
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NativePHP/electron#143
src/Client/Client.php
: PowerMonitor passes parameters to one of its endpoints. Unfortunately, they were not sent by the client.PowerMonitor::class
now implementsContracts\PowerMonitor::class
interfaceFacades\PowerMonitor::fake()
swaps implementations with a test double concretePowerMonitorFake::class
with assertion helpersPowerMonitorFake::class
assertions workI plan to submit another PR with a fix for
phpstan.neon
, which is currently not working, and add a GitHub action to check every push.