feat: phpstan level 5 #446

SRWieZ · 2024-12-12T09:48:42Z

Put the entire project through PHPStan level 5.

Found some bugs that are now fixed.
I made one change per commit and recommend keeping them, even though I had some trouble understanding one test bench error. 😅
One fix is duplicated from Fixes and improvements to powerMonitor #445, but it shouldn't cause any merge issues.
I don't know why static analysis won't be applied to this PR.
Added a composer qa script to ensure code quality assurance.
There is an alternative to 585fb47, but it would involve breaking changes. Unfortunately, asymmetrical visibility has only been available since PHP 8.4.

…he constructor

This reverts commit cac9ea1.

…uired" This reverts commit cc1cb87.

This reverts commit 6b88d13.

SRWieZ · 2024-12-12T11:15:21Z

Ready for review!

SRWieZ added 19 commits December 12, 2024 10:47

feat: phpstan level 5

933c8e5

fix: $database undefined

91c5275

fix: Unsafe usage of new static()

5be8381

fix: ignore NativeAppServiceProvider not existing

f009309

fix: FreshCommand constructor invoked with 1 parameter, 0 required

cc1cb87

fix: MenuBuilder facade function duplicates and arguments

03bd832

fix: Type void cannot be part of a union type declaration.

3c7e958

fix: Php compactor missing imports and return statement

f0a5baf

fix: missing SeedDatabaseCommand@handle return statement

7ebe7f9

Fix: cannot assign a value to a public readonly property outside of t…

585fb47

…he constructor

Fix: PowerMonitor invoked Client::get() with 2 parameters, 1 required

8fb93e9

fix: alternative for FreshCommand migrator argument

cac9ea1

Revert "fix: alternative for FreshCommand migrator argument"

7aa74f1

This reverts commit cac9ea1.

Revert "fix: FreshCommand constructor invoked with 1 parameter, 0 req…

d1a90f4

…uired" This reverts commit cc1cb87.

fix: trying something

6b88d13

fix: phpstan.yml

36ff261

Revert "fix: trying something"

c3c2e63

This reverts commit 6b88d13.

fix: trying to lower the minimum laravel 10 dependency

2ce6334

fix: final fix 🎉

b9dc748

SRWieZ marked this pull request as ready for review December 12, 2024 11:15

Provide feedback