Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test workflow #323

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Fix test workflow #323

merged 3 commits into from
Jul 16, 2024

Conversation

spilth
Copy link
Collaborator

@spilth spilth commented Jul 16, 2024

Problem

  • The mysql2 gem is incompatible with the latest MySQL client provided by Homebrew on macOS, preventing bundle install from completing successfully
  • A number of gems have vulnerabilities at the current versions which cause the bundle-audit check task to fail the build
  • The current checkout action is deprecated and needs to be upgraded

Solution

  • Upgrade the mysql2 gem version.
  • Upgrade the gem versions of vulnerable gems.
    • Note that view_component is now pinned to a 2.X version to avoid upgrading to 3.x (which likely requires some research/testing).
  • Upgrade the version of actions/checkout being used.

Type

Dependencies

@spilth spilth mentioned this pull request Jul 16, 2024
@spilth spilth requested review from mnyrop and ekate July 16, 2024 14:52
Copy link
Member

@mnyrop mnyrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and can confirm that everything works locally with the upgraded gems 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants