Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test workflow #321

Closed
wants to merge 3 commits into from
Closed

Conversation

spilth
Copy link
Collaborator

@spilth spilth commented Jun 30, 2024

Hi folks,

While playing with a fork of this project I ran into some issues locally and on CI. I thought it might be helpful to share what fixed the issues I was encountering.

Problem

  • The mysql2 gem is incompatible with the latest MySQL client provided by Homebrew on macOS, preventing bundle install from completing successfully
  • A number of gems have vulnerabilities at the current versions which cause the bundle-audit check task to fail the build
  • The current checkout action is deprecated and needs to be upgraded

Solution

  • Upgrade the mysql2 gem version.
  • Upgrade the gem versions of vulnerable gems.
    • Note that view_component is now pinned to a 2.X version to avoid upgrading to 3.x (which likely requires some research/testing).
  • Upgrade the version of actions/checkout being used.

Type

Dependencies

@spilth
Copy link
Collaborator Author

spilth commented Jul 16, 2024

Moving this to an official branch/PR now that I'm working on this repository - #323

@spilth spilth closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant