Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to psy4 #383

Merged
merged 18 commits into from
Jul 8, 2024
Merged

update to psy4 #383

merged 18 commits into from
Jul 8, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 2, 2024

No description provided.

@jd-lara jd-lara requested a review from rodrigomha July 2, 2024 15:24
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Performance Results

Version Precompile Time
Main 2.199921851
This Branch 1.964479446
Version Execute Time
Main-Build ResidualModel 8.487370133
Main-Execute ResidualModel 17.669596422
Main-Build MassMatrixModel 0.583796297
Main-Execute MassMatrixModel 31.478367488
This Branch-Build ResidualModel 7.942197734
This Branch-Execute ResidualModel 17.005973023
This Branch-Build MassMatrixModel 0.591559311
This Branch-Execute MassMatrixModel 31.462808502

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

HaleyRoss and others added 7 commits July 8, 2024 09:12
* Add current limiters to inner_conrol_models

* Fix limiter integration mistakes

* Add saturation limiting logic

* Add hybrid limiter control logic

* Correct sign error hybrid limiter

* Remove print

* Change PowerSystems version

* modify inner control gain

* debug

* fix mag limiter

* change placement of kiv in hyblim

* debug load

* revert debug

---------

Co-authored-by: Rodrigo Henríquez-Auba <[email protected]>
@jd-lara jd-lara merged commit 6e428a1 into main Jul 8, 2024
6 of 7 checks passed
@jd-lara jd-lara deleted the jd/psy4_update branch October 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants